Skip to content

Support config of webpack-extension-reloader #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Support config of webpack-extension-reloader #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,12 @@ module.exports = {

See [Component options](#component-options).

- **extensionReloaderOptions**

- Type: `Object.<string, Object>`

See available options in [webpack-extension-reloader](https://github.com/rubenspgcavalcante/webpack-extension-reloader#how-to-use).

- **manifestSync**

- Type: `Array<string>`
Expand Down
4 changes: 3 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const manifestTransformer = require('./lib/manifest')
const defaultOptions = {
components: {},
componentOptions: {},
extensionReloaderOptions: {},
manifestSync: ['version'],
modesToZip: ['production'],
manifestTransformer: null
Expand All @@ -24,6 +25,7 @@ module.exports = (api, options) => {
? Object.assign(defaultOptions, options.pluginOptions.browserExtension)
: defaultOptions
const componentOptions = pluginOptions.componentOptions
const extensionReloaderOptions = pluginOptions.extensionReloaderOptions
const packageJson = require(api.resolve('package.json'))
const isProduction = api.service.mode === 'production'
const keyFile = api.resolve('key.pem')
Expand Down Expand Up @@ -105,7 +107,7 @@ module.exports = (api, options) => {
// configure webpack-extension-reloader for automatic reloading of extension when content and background scripts change (not HMR)
// enabled only when webpack mode === 'development'
if (!isProduction) {
webpackConfig.plugin('extension-reloader').use(ExtensionReloader, [{ entries }])
webpackConfig.plugin('extension-reloader').use(ExtensionReloader, [{ entries, ...extensionReloaderOptions }])
}

webpackConfig.plugin('copy').tap((args) => {
Expand Down