From f46e47685753e922ead0f4de30faac199b2fcbe1 Mon Sep 17 00:00:00 2001 From: Adam Bullmer Date: Thu, 21 Nov 2019 02:40:13 -0600 Subject: [PATCH 1/2] fix detection of when to disable user script optimization Fixes #66 --- index.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/index.js b/index.js index 2f92ceb..c2cc936 100644 --- a/index.js +++ b/index.js @@ -118,9 +118,13 @@ module.exports = (api, options) => { api.configureWebpack((webpackConfig) => { const omitUserScripts = ({ name }) => !userScripts.includes(name) - if (isProduction) { - webpackConfig.optimization.splitChunks.cacheGroups.vendors.chunks = omitUserScripts - webpackConfig.optimization.splitChunks.cacheGroups.common.chunks = omitUserScripts + if (webpackConfig.optimization && webpackConfig.optimization.splitChunks && webpackConfig.optimization.splitChunks.cacheGroups) { + if (webpackConfig.optimization.splitChunks.cacheGroups.vendors) { + webpackConfig.optimization.splitChunks.cacheGroups.vendors.chunks = omitUserScripts + } + if (webpackConfig.optimization.splitChunks.cacheGroups.common) { + webpackConfig.optimization.splitChunks.cacheGroups.common.chunks = omitUserScripts + } } }) } From 6dda6a553122deccb58c023f92853314150a5856 Mon Sep 17 00:00:00 2001 From: Adam Bullmer Date: Thu, 21 Nov 2019 02:41:26 -0600 Subject: [PATCH 2/2] v0.23.1 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 942f197..f389e4e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "vue-cli-plugin-browser-extension", - "version": "0.23.0", + "version": "0.23.1", "description": "Browser extension development plugin for vue-cli 3.0", "main": "index.js", "scripts": {