Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upIP Address Check Returns HTML #291
Closed
Comments
adamcaudill
added a commit
that referenced
this issue
Nov 30, 2019
* Merge #285 w/ CR Changes (#296) * Bump validator-collection from 1.3.6 to 1.3.7 Bumps [validator-collection](https://github.com/insightindustry/validator-collection) from 1.3.6 to 1.3.7. - [Release notes](https://github.com/insightindustry/validator-collection/releases) - [Changelog](https://github.com/insightindustry/validator-collection/blob/master/CHANGES.rst) - [Commits](insightindustry/validator-collection@v.1.3.6...v.1.3.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update requirements.txt * Bump packaging from 19.1 to 19.2 Bumps [packaging](https://github.com/pypa/packaging) from 19.1 to 19.2. - [Release notes](https://github.com/pypa/packaging/releases) - [Changelog](https://github.com/pypa/packaging/blob/master/CHANGELOG.rst) - [Commits](pypa/packaging@19.1...19.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump urllib3 from 1.25.3 to 1.25.5 Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.25.3 to 1.25.5. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/master/CHANGES.rst) - [Commits](urllib3/urllib3@1.25.3...1.25.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump urllib3 from 1.25.5 to 1.25.6 Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.25.5 to 1.25.6. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/master/CHANGES.rst) - [Commits](urllib3/urllib3@1.25.5...1.25.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump mypy from 0.720 to 0.730 Bumps [mypy](https://github.com/python/mypy) from 0.720 to 0.730. - [Release notes](https://github.com/python/mypy/releases) - [Commits](python/mypy@v0.720...v0.730) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Multi-Cookie Logic At line 71: Added logic which check for multiple cookies supplied in the cookie flag. Separation is performed on the semi-colon character. I apologize if I did this wrong. Original code: if cookie is not None and len(cookie) > 0: if "=" in cookie: name = cookie.split("=", 1)[0] val = cookie.split("=", 1)[1] c = requests.cookies.create_cookie(name=name, value=val) _requester.cookies.set_cookie(c) else: output.error( f"Invalid cookie specified ({cookie}) - cookie must be in NAME=VALUE format. Ignored." ) * Fix invalid responses to get IP address Fixes #291 H/T @brandonlw * Fix package building * Update setup.py & Pipfile to fix build * Fix macOS build * Bump psutil from 5.6.6 to 5.6.7 Bumps [psutil](https://github.com/giampaolo/psutil) from 5.6.6 to 5.6.7. - [Release notes](https://github.com/giampaolo/psutil/releases) - [Changelog](https://github.com/giampaolo/psutil/blob/master/HISTORY.rst) - [Commits](giampaolo/psutil@release-5.6.6...release-5.6.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Restyled by black * Update to addres feedback * Update docs and fix build * Revert version change * Bump rubyzip from 1.2.3 to 2.0.0 in /docs Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 1.2.3 to 2.0.0. - [Release notes](https://github.com/rubyzip/rubyzip/releases) - [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md) - [Commits](rubyzip/rubyzip@v1.2.3...v2.0.0) Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the check to get the public IP address is blocked, such as by an egress filtering system, HTML may be returned instead of the IP address. Checks should be added to prevent this HTML from being dumped out to the screen.
Issue found by @brandonlw