Ignore installed external packages #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a release note above the 1.1.1 header in HISTORY.rst Also I think 'Add support' is a bit of a misnomer, perhaps 'Ignore installed external packages' is a better description. True support would be being able to check what's specified in requirements.txt is installed. I think for this we should also only be filtering them out of the |
seporaitis
changed the title
|
Thanks, I hope to have a deeper look at it over the weekend! |
adamchainz
approved these changes
Jul 25, 2018
adamchainz
added a commit
that referenced
this pull request
Jul 25, 2018
This reverts commit 61fb505.
|
Released in https://pypi.org/project/pip-lock/1.2.0/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per requirements.txt documentation - add support for external packages.
Currently
pip-lockfails with exceptionValueError: not enough values to unpack (expected 2, got 1)if it encounters external package inpip freezeoutput.