Merge branch #13

Merged
merged 2 commits into from Apr 17, 2012

Projects

None yet

2 participants

@thadcodes
Contributor

fixed issues for #10 and #11

@adamdbradley adamdbradley merged commit cc56438 into adamdbradley:master Apr 17, 2012
@adamdbradley
Owner

I put a try/catch within the triggerImageEvent just to prevent the errors which IE8 was having. Would you be able to take a look at your triggerImageEvent function and make sure its works with IE?

@thadcodes
Contributor

Sorry about that Adam. I've been out of town this weekend but I'll get
into this sometime today if I can.

On Fri, Apr 27, 2012 at 7:30 PM, Adam Bradley <
reply@reply.github.com

wrote:

I put a try/catch within the triggerImageEvent just to prevent the errors
which IE8 was having. Would you be able to take a look at your
triggerImageEvent function and make sure its works with IE?


Reply to this email directly or view it on GitHub:
#13 (comment)

@thadcodes
Contributor

It appears that IE8 will not allow custom events. The only way to support it is through a hack of using a standard event and passing custom properties on the event object http://stackoverflow.com/questions/2028456/how-to-fire-personal-event-in-javascript. The other option is to add a framework and start using their event model but that would increase the required weight. I suggest for the time being that the events are IE9+ support only. I'll commit code to make sure browsers that don't support custom events don't try to execute them shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment