Adam DiCarlo adamdicarlo

adamdicarlo commented on issue Workiva/karma-jspm#40
Adam DiCarlo

Ah, cool. FWIW, in our case the problem was simply "whoops, Karma's trying to load our gulpfile" (needed to change an exclude list after switching …

adamdicarlo commented on issue Workiva/karma-jspm#40
Adam DiCarlo

Not sure what the exactly problem/solution is, but PhantomJS (1.x; don't know about 2.x) does not support Function.prototype.bind -- so that may be…

adamdicarlo commented on pull request cgarvis/angular-toggle-switch#54
Adam DiCarlo

Is this merge worthy? Anything I can do to clean it up?

Adam DiCarlo

Just saw this on another generator (aurelia), only after upgrading yeoman (from 1.1.x to 1.4.5), so I'm guessing Yeoman changed its api recently an…

adamdicarlo commented on pull request newrelic-forks/redis-semaphore#3
Adam DiCarlo

:+1:

Adam DiCarlo
Adam DiCarlo
Adam DiCarlo
  • Adam DiCarlo e3d08d5
    Add amd-wrap build script.
adamdicarlo commented on pull request cgarvis/angular-toggle-switch#54
Adam DiCarlo

Re-pushed without the Update build commit.

Adam DiCarlo

I'd rather my own build do the minification (and have the option to generate a source map, which is not included in angular-toggle-switch). Mostly …

Adam DiCarlo newrelic is now a83975c
adamdicarlo commented on pull request cgarvis/angular-toggle-switch#54
Adam DiCarlo

(Will re-push without the 'Update build' commit tomorrow)

adamdicarlo commented on pull request cgarvis/angular-toggle-switch#54
Adam DiCarlo

to keep the expect() simple in the tests -- since jQuery isn't available, I wasn't sure how exactly to do the equivalent of e.g., elm.find('.knob-l…

adamdicarlo commented on pull request cgarvis/angular-toggle-switch#54
Adam DiCarlo

Yes; because it was impossible to specify an empty label via a directive attribute. foo = ''; !foo; // true angular.isUndefined(foo); // false You…

adamdicarlo commented on pull request cgarvis/angular-toggle-switch#54
Adam DiCarlo

Ah, did you want me to remove the "Update build" commit from this PR?

adamdicarlo commented on pull request cgarvis/angular-toggle-switch#54
Adam DiCarlo

I'd suggest bumping major version if you merge this, due to the CSS change.

Adam DiCarlo
Allow empty labels, move state CSS class to outer div.
3 commits with 41 additions and 16 deletions
Adam DiCarlo
adamdicarlo commented on pull request switer/chainjs#1
Adam DiCarlo

I haven't actually tried running the tests, by the way! That needs to be done.

adamdicarlo opened pull request switer/chainjs#1
Adam DiCarlo
Fix 'use strict' declaration.
1 commit with 1 addition and 1 deletion
Adam DiCarlo
  • Adam DiCarlo 2e75aae
    Fix 'use strict' declaration.