Fixes for argument mutations when calling view methods #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments start with "#" or ";", and no inline comments. See: https://editorconfig-specification.readthedocs.io/
- no more mutation of arguments in _call_method_name() - fixed broad TypeError except in _call_method_name() - it was shadowing exceptions - result of parse_call_method_name is now immutable (which ends up in lru_cache) - updated related tests
adamghill
reviewed
Nov 17, 2022
| @@ -81,10 +83,10 @@ def validate_checksum(self): | |||
|
|
|||
|
|
|||
| class Return: | |||
| def __init__(self, method_name, args=[], kwargs={}): | |||
| def __init__(self, method_name, args=None, kwargs=None): | |||
|
Thank you so much for digging into this bug and making this PR. I can't believe I never ran into it while testing. I really appreciate it and will merge it into |
|
@all-contributors add @stat1c-void for code and tests |
|
I've put up a pull request to add @stat1c-void! 🎉 |
|
Nice, cheers! |
|
I just published 0.49.2 to https://pypi.org/project/django-unicorn/. Thanks again for the fixes. 🦄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experiencing a problem with Unicorn, so here are some fixes.
Given: a component view method with single argument, type-hinted as a Model.
Problem: consecutive calls to the method with the same arguments would result in successful first call, but exceptions in next calls. Behavior repeats with restart of a worker.
It would seem that
parse_call_method_name()output in thelru_cachewould later be mutated, resulting in incorrect caching.P.S. And a few other fixes - I noticed some small problems on the way.