Caching with parent/children multiple levels #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… back when un-caching. Simplify setting parent/child releationships.
adamghill
reviewed
Feb 22, 2023
| # If no parent, mark that the component has its children set. | ||
| # This works because the nested (internal) components get rendered first before the parent, | ||
| # so once we hit a component without a parent we know all of the children have been rendered correctly | ||
| # TODO: This might fall apart with a third layer of nesting components |
There was a problem hiding this comment.
This might fall apart with a third layer of nesting components
😂
|
Thanks for digging into this. First glance looks good, I should be able to test in detail over the next few days! |
|
Sorry this took so long, this looks good. I'm going to merge it in and bump the version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When caching, switch children and parents to dummy references. Switch back when un-caching. Simplify setting parent/child releationships.