Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loading.attr, loading.class, etc on elements other than the current action element #512

Merged
merged 3 commits into from
Mar 18, 2023

Conversation

bazubii
Copy link
Contributor

@bazubii bazubii commented Feb 22, 2023

loading.attr, loading.class, etc are handled in element.handleLoading(); Component.handleLoading only calls that on the targetElement. It should call it on all loading elements, the same as hide/show

@bazubii
Copy link
Contributor Author

bazubii commented Feb 22, 2023

I added another bug to this PR. When an event fires, it mutates the action name to fill in $event or $returnValue. For keyup, this makes $event.target.value useless as it overwrites with the value on the first keyup, and never updates it.

@adamghill adamghill force-pushed the george/loading_attr_class_support branch from 1148ab0 to de4c663 Compare March 18, 2023 12:55
@adamghill adamghill merged commit de4c663 into adamghill:main Mar 18, 2023
@adamghill
Copy link
Owner

Thanks for this fix! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants