Pass "data" as a keyword argument when instantiating form_class #552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem using AuthenticationForm as form_class in UnicornView due to the extra
request
argument in the forms constructor. This caused form data to be passed incorrectly in _get_form and was fixed by simply changing "data" to a keyword argument.My component:
Cause the error:
While not necessarily condoning the use of authentication forms with unicorn, a temporary fix to a problem like this can be solved by inheriting the form class and changing
init
, like this:Great work on Unicorn by the way