New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to leave tar archive open after stream is closed #337

Merged
merged 4 commits into from Jan 14, 2018

Conversation

Projects
None yet
2 participants
@4ybaka
Contributor

4ybaka commented Jan 4, 2018

I'm not sure if this flag should be included in WriterOptions since no other archives could support it. Moreover zip archive also has finalization logic but there is no sense to leave it open since it is not possible to resume zip archive writing (correct me if I'm wrong and I'll move this flag to WriterOptions).

If there are no objections with this approach - I'll add tests for these changes.
Related to #323

@adamhathcock

This comment has been minimized.

Owner

adamhathcock commented Jan 12, 2018

I think the option should be on TarWriterOptions like there is a ZipWriterOptions

4ybaka added some commits Jan 12, 2018

@4ybaka

This comment has been minimized.

Contributor

4ybaka commented Jan 12, 2018

Moved to TarWriterOptions and added tests.

@adamhathcock adamhathcock merged commit f893c12 into adamhathcock:master Jan 14, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment