Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how missing parts are handled #569

Conversation

BrendanGrant
Copy link
Contributor

@BrendanGrant BrendanGrant commented Feb 13, 2021

I have been doing some work involving processing incomplete RAR files and file sets, and I had to make a few tweaks to make SharpCompress ok with trying to read the partial data and figured they useful enough to share.

Copy link
Owner

@adamhathcock adamhathcock left a comment

Always useful to have more options like this. Thanks!

@adamhathcock adamhathcock merged commit 6f08bb7 into adamhathcock:master Feb 14, 2021
0 of 2 checks passed
@BrendanGrant
Copy link
Contributor Author

@BrendanGrant BrendanGrant commented Feb 14, 2021

I'm pleased you like the option, however I didn't expect you to merge it so quick as the tests are failing (I'd never actually run them myself as the changes were so small). One is an easy fix, just changing the expected exception, the others require a good bit more consideration as I think they are making some assumptions which aren't always accurate.

@adamhathcock
Copy link
Owner

@adamhathcock adamhathcock commented Feb 15, 2021

Actually the fix was better split detection by default: a51b563

I knew things were failing but I like merging in good ideas. If you're not done, consider using the Draft PR feature. Can discuss without worrying about a quick merge if you're not ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants