Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not place extension classes in common namespace #579

Conversation

Looooong
Copy link
Contributor

@Looooong Looooong commented Mar 18, 2021

Do not place extension classes in common namespace, as the extension methods might conflict with the same counterpart (same name, same signature) from another separated namespace.

aisk
aisk approved these changes Mar 18, 2021
@Looooong Looooong force-pushed the fix/do-not-place-extention-classes-in-common-namespace branch from 8d13080 to 237ff9f Compare Mar 18, 2021
@adamhathcock
Copy link
Owner

@adamhathcock adamhathcock commented Mar 18, 2021

Thanks!

@adamhathcock adamhathcock merged commit cfef228 into adamhathcock:master Mar 18, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants