Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade System.Memory to fix buffer version issue #592

Merged
merged 2 commits into from Jun 4, 2021

Conversation

adamhathcock
Copy link
Owner

@adamhathcock adamhathcock commented Apr 24, 2021

No description provided.

@schlotter
Copy link

schlotter commented Apr 26, 2021

Thank you! I can confirm this PR fixes bug #591.

@@ -35,7 +35,8 @@
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<PackageReference Include="System.Text.Encoding.CodePages" Version="5.0.0" />
<PackageReference Include="System.Memory" Version="4.5.4" />
<PackageReference Include="System.Memory" Version="4.5.3" />
<PackageReference Include="System.Buffers" Version="4.4.0" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment could be added that the System.Buffers package reference can be removed as soon as dotnet/runtime#1830 is fixed?

@schlotter
Copy link

schlotter commented May 21, 2021

Hi @adamhathcock!

This looks good to me. Do you plan to merge?

Best regards,
Christian

@adamhathcock adamhathcock merged commit 8ee257d into master Jun 4, 2021
2 of 4 checks passed
@adamhathcock adamhathcock deleted the memory-downgrade branch Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants