Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally parse Zip64 extra field based on specification #596

Conversation

DannyBoyk
Copy link
Contributor

@DannyBoyk DannyBoyk commented Apr 26, 2021

The Zip64 extra field should look for values based on the corresponding
values in the local entry header.

Fixes #595

The Zip64 extra field should look for values based on the corresponding
values in the local entry header.

Fixes adamhathcock#595
@runemoennike
Copy link

@runemoennike runemoennike commented May 25, 2021

@DannyBoyk thanks for solving this! It's incredible how many differences there can be in an outwardly standardised file format :D

@adamhathcock any plans for merging this into an upcoming release? :) We would love to have this fix from the nuget package instead of changing our dependency.

@adamhathcock adamhathcock merged commit e07046a into adamhathcock:master Jun 4, 2021
2 checks passed
@adamhathcock
Copy link
Owner

@adamhathcock adamhathcock commented Jun 4, 2021

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants