Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for TarWriter - too much padding in large files #610

Merged
merged 2 commits into from Sep 12, 2021

Conversation

cyr
Copy link
Contributor

@cyr cyr commented Aug 27, 2021

For large files, due to how the padding was calculated an additional 512 bytes was added. I noticed this while archiving a file (size 11721453867 bytes, i.e. 11gb, roughly) and 725 null bytes were added as padding, instead of 213. This new method calculates large sizes correctly (and is faster!).

@adamhathcock
Copy link
Owner

@adamhathcock adamhathcock commented Sep 12, 2021

Could you update the PR with the latest master to make this mergable?

@cyr
Copy link
Contributor Author

@cyr cyr commented Sep 12, 2021

Done!

@adamhathcock
Copy link
Owner

@adamhathcock adamhathcock commented Sep 12, 2021

Thanks!

@adamhathcock adamhathcock merged commit 7bd9711 into adamhathcock:master Sep 12, 2021
2 checks passed
@adamhathcock
Copy link
Owner

@adamhathcock adamhathcock commented Sep 12, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants