Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing to seek empty zip files #611

Merged

Conversation

Thunderstr1k3
Copy link

@Thunderstr1k3 Thunderstr1k3 commented Sep 2, 2021

In our workflow it may happen that we attempt to access zip files that don't actually have any content. Until earlier versions that worked, but with the last implementation of SeekableZipHeaderFactory it fails. I suggest parsing the entire stream instead of skipping the oecd region. Respective unit test is added, too.

If you accept the changes, please publish a new nuget package.

Best regards

@bormm
Copy link

@bormm bormm commented Sep 6, 2021

Hi @adamhathcock, I am the team lead of the Foxit Europe Enterprise Solutions cloud team. We are hanging because of this problem. OpenSource should not reduced to "consuming free stuff", but also on giving back to the project. So my team decided to not just "report the issue" but provide a PR to fix it here. Is there anything development related that can be done by my team to support you merging this request and providing a new nupkg? Like extending the automatic checks here or something?

Thank you for your work!

@adamhathcock
Copy link
Owner

@adamhathcock adamhathcock commented Sep 12, 2021

I only just noticed this. It smells okay and thanks for providing a test!

@adamhathcock adamhathcock merged commit b425659 into adamhathcock:master Sep 12, 2021
2 checks passed
@adamhathcock
Copy link
Owner

@adamhathcock adamhathcock commented Sep 12, 2021

Released in https://github.com/adamhathcock/sharpcompress/releases/tag/0.29.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants