Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Canvas #33

Closed
jessvu opened this issue Feb 3, 2021 · 8 comments
Closed

Static Canvas #33

jessvu opened this issue Feb 3, 2021 · 8 comments
Assignees
Labels
view User interface type

Comments

@jessvu
Copy link
Collaborator

jessvu commented Feb 3, 2021

image

https://docs.google.com/presentation/d/1GPby059FlA5RSSo-xBiE1HTkOOstBC17VkPuwfrTWzA/edit#slide=id.gb5e38bc965_0_9

I'm wondering if on OSD you could zoom the image out a little bit so that there's padding above and below the image and make the entire canvas area (including the image) static for the LOC staff user testing. I'm imagining this to be the default view of the canvas at the most zoomed out state upon entry of the application.

I would still like for the zooming in/out functionality to work, but when the canvas is zoomed out all the way and the whole image can be seen, if we could disable the ability to move it, I think it would solve for the concerns we have about jumpiness. I understand if this is another limitation of OSD, just wanted to share my idea in case it's doable task.

@adamjarling adamjarling self-assigned this Feb 4, 2021
@adamjarling adamjarling added the view User interface type label Feb 4, 2021
@adamjarling
Copy link
Owner

@jessvu So I have this now working where the image and canvas will render zoomed out 100%, and are static.

OSD offers a configuration option visibilityRatio (https://openseadragon.github.io/docs/OpenSeadragon.html#.Options) which essentially tells OSD how much of the image needs to stay inside the bounds of OSD's canvas. By default the value is 0.5, allowing a user to pan to the greatest level, only see half the image in the OSD canvas.

I updated this setting to 1, which tells OSD to keep the entire image constrained within the canvas. Along with some other default zoom settings, I was able to get the image to display with some perceived margins around all edges of the image.

However, because we're looking at this from a laptop viewport (I assume....desktop may be different), the viewport is wider than tall, and there are no issues showing extra horizontal padding until a very zoomed-in level. This means that horizontal padding is disabled, until a zoom level is reached where the image zoom level is wider than current canvas. Maybe this is fine...to me it seems a little odd that I can pan vertically but not horizontally until a certain point, but my bias is I'm used to looking at deep zoom image viewers more than the average person.

So...I'll push up the changes and let me know yea/nea?

image

@adamjarling
Copy link
Owner

Actually still working on this. I'll ping you when it's pushed live @jessvu

@adamjarling
Copy link
Owner

Ok, just pushed the changes.

@adamjarling
Copy link
Owner

Just noticed the original size of the image on the canvas (for tall items), doesn't have top/bottom margin. Need to figure out a better way to display the initial image size with margins all around, and (I think) set a dynamic minimum Zoom level in OpenSeadragon each time a new image is loaded into the Viewer.

@jaimemears
Copy link
Collaborator

The top/bottom margin has not been implemented, correct? (Doing backlog cleanup)

@adamjarling
Copy link
Owner

Correct, not yet implemented. Since we're limiting how a user can move a Work around the OpenSeadragon viewer, I was running into problems getting the initial top margins consistent, per Work. I'll revisit this.

@jaimemears
Copy link
Collaborator

@adamjarling I noticed with the return to a more "moveable" item in open sea dragon the margins have gone away. Is this an either/or situation? Meaning you cant have top and bottom margins and a moveable item simultaneously?

@jaimemears
Copy link
Collaborator

@adamjarling nvm! the items look centered in this newest push. Closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
view User interface type
Projects
None yet
Development

No branches or pull requests

3 participants