New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI support #163

Open
wants to merge 42 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@tsibley
Contributor

tsibley commented Jan 18, 2015

Testing on 5.6 through blead via Travis. I fixed a number of problems with the tests, mostly regarding Perl 5.6, so that Travis would succeed. You can see the results for my fork, but the repo owner (@adamkennedy) will need to flip the switch for Travis on the primary repo.

guillaumeaubert and others added some commits Mar 21, 2014

unit test all PPI::Statement::Sub methods
Conflicts:
	t/ppi_statement_sub.t
PPI::Test::pragmas for test files instead of boilerplate
Conflicts:
	t/ppi_statement_package.t
	t/ppi_statement_sub.t
	t/ppi_token_operator.t
Note that PPI::Token::Quote::Double::simplify does
not require that the caller call flush_locations
on the document.

moregan and others added some commits Nov 26, 2014

Merge t/20_tokenizer_regression.t into t/21_exhaustive.t
Conflicts:
	t/20_tokenizer_regression.t
	t/21_exhaustive.t

Conflicts:
	t/20_tokenizer_regression.t
	t/21_exhaustive.t
Actually skip all of xt/api.t when not release testing
plan() expects only skip_all, not a test count, or it won't skip
anything.  The test pragmas import is moved after the BEGIN block so
that it doesn't import Test::NoWarnings which will run a test at exit,
breaking the plan to skip everything.  I ensure that strict and warnings
are still loaded for the BEGIN block, though, by making them explicit.
Travis CI config, using haarg's Travis Perl helpers
The helpers are necessary to easily test on 5.6, and they're just plain
nice regardless.
Properly skip all tests, including the warnings test, in t/14_charsets.t
On perls older than 5.8.7 when Unicode tests are skipped, the
auto-imported Test::NoWarnings still ran a single test just before exit.
This broke our skip everything plan and caused the test file to fail.

An alternative solution might be a two-stage load of the
PPI::Test::pragmas, but the simplest solution for now is moving it later
in the file and explicitly importing strict/warnings to preserve those
semantics for the BEGIN block.

Switch from calling Test::More->import(...) + exit(0) to the simpler and
documented interface of plan().
Fix mis-parsed interpolation for testing on 5.6
The previous syntax, while fine on 5.8+, results in the following fatal
compilation errors on 5.6:

    Global symbol "%bs" requires explicit package name at t/ppi_token_quotelike_words.t line 59.
    Global symbol "@bs" requires explicit package name at t/ppi_token_quotelike_words.t line 61.
    Execution of t/ppi_token_quotelike_words.t aborted due to compilation errors.

I believe that concatenating, rather than interpolating, should produce
the correct test string on all Perl versions.
Catch "Misplaced _ in number" warnings from 5.6
If a Test::Warn dep isn't acceptable, the offending tests could be
skipped on 5.6 instead.
@moregan

This comment has been minimized.

Show comment
Hide comment
@moregan

moregan Jan 19, 2015

Collaborator

I believe that commits in this PR make redundant #145

Collaborator

moregan commented Jan 19, 2015

I believe that commits in this PR make redundant #145

@tsibley

This comment has been minimized.

Show comment
Hide comment
@tsibley

tsibley Jan 19, 2015

Contributor

Whoops. I should have known to look for patches first!

Contributor

tsibley commented Jan 19, 2015

Whoops. I should have known to look for patches first!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment