Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE Support #8

Closed
victorwpbastos opened this issue Nov 4, 2012 · 3 comments
Closed

IE Support #8

victorwpbastos opened this issue Nov 4, 2012 · 3 comments

Comments

@victorwpbastos
Copy link

I did some modifications in the code for compatibility with IE 6,7,8 and 9.
If you want i can do a pull request! let me know, ok?
@adammark
Copy link
Owner

adammark commented Nov 7, 2012

Sure, happy to take a look. I never tested in IE, but I assume I'll need a shim for String.trim (easy) and the ability to pass functions to RegExp.replace (hard?)

@victorwpbastos
Copy link
Author

in fact i just changed a few lines of code. I'll fork your repository e send you a pull request.

@victorwpbastos victorwpbastos reopened this Nov 8, 2012
@victorwpbastos
Copy link
Author

Pull request: #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adammark @victorwpbastos