Little modifications for IE 6, 7 and 8 compatibility #10

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@victorwpbastos

Check the modifications in code. I ran all the tests fine!

@victorwpbastos victorwpbastos referenced this pull request Nov 8, 2012

Closed

IE Support #8

@adammark

This comment has been minimized.

Show comment Hide comment
@adammark

adammark Nov 8, 2012

Owner

This looks good so far. Rather than use the splice() shim, I'm going to rewrite the two existing splice() calls. Less code.

Owner

adammark commented Nov 8, 2012

This looks good so far. Rather than use the splice() shim, I'm going to rewrite the two existing splice() calls. Less code.

@adammark

This comment has been minimized.

Show comment Hide comment
@adammark

adammark Nov 8, 2012

Owner

Pulled in your trim() shim and rewrote splice() calls. Tested in IE9 but not older versions. Can you grab the latest and confirm for IE7-8? (not concerned about 6). Thanks!

Owner

adammark commented Nov 8, 2012

Pulled in your trim() shim and rewrote splice() calls. Tested in IE9 but not older versions. Can you grab the latest and confirm for IE7-8? (not concerned about 6). Thanks!

@victorwpbastos

This comment has been minimized.

Show comment Hide comment
@victorwpbastos

victorwpbastos Nov 24, 2012

I did some little changes in sort and join pipes and all the tests ran fine!

I did some little changes in sort and join pipes and all the tests ran fine!

@adammark

This comment has been minimized.

Show comment Hide comment
@adammark

adammark Feb 25, 2013

Owner

Closing out—added these capabilities. Note code doesn't use Array.indexOf(). Thanks again!

Owner

adammark commented Feb 25, 2013

Closing out—added these capabilities. Note code doesn't use Array.indexOf(). Thanks again!

@adammark adammark closed this Feb 25, 2013

@victorwpbastos

This comment has been minimized.

Show comment Hide comment
@victorwpbastos

victorwpbastos Mar 2, 2013

adammark, the toggle pipe uses the indexOf() method. Removing this shim will break in IE 6-8.

adammark, the toggle pipe uses the indexOf() method. Removing this shim will break in IE 6-8.

@adammark

This comment has been minimized.

Show comment Hide comment
@adammark

adammark Mar 2, 2013

Owner

Good catch. I will try to refactor without the shim.

On Mar 1, 2013, at 9:23 PM, victorwpbastos notifications@github.com wrote:

adammark, the toggle pipe uses the indexOf() method. Removing this shim will break in IE 6-8.


Reply to this email directly or view it on GitHub.

Owner

adammark commented Mar 2, 2013

Good catch. I will try to refactor without the shim.

On Mar 1, 2013, at 9:23 PM, victorwpbastos notifications@github.com wrote:

adammark, the toggle pipe uses the indexOf() method. Removing this shim will break in IE 6-8.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment