Adam Ralph
adamralph

Organizations

@FakeItEasy @xbehave @liteguard @scriptcs @config-r @Particular @bau-build @colored-console @ParticularLabs
Aug 25, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#837
@adamralph

You could even call them @ref and @out.

Aug 24, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#837
@adamralph

nitpick: the variables referred to as refParameter and outParameter" are really just variables. The method has "out and ref parameters" and the var…

Aug 25, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#837
@adamralph

nitpick: it's called "ref parameter" elsewhere in the natural language.

Aug 24, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#837
@adamralph

I guess the point I'm trying to make is that the natural language should adequately describe the scenario on it's own. I.e. you should be able to t…

Aug 24, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#837
@adamralph

I.e. ignoring out for a moment (perhaps it's better to split the scenario?) you could write the scenario like so: Given an object with a method tha…

Aug 24, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#837
@adamralph

You shouldn't really do anything outside steps. The entire body of the test should really be inside the step delegates. Doing some stuff outside th…

Aug 24, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#837
@adamralph

I never know where to initialize things in XBehave specs If the initialisation is a first class part of the scenario, then it should be mentioned…

Aug 24, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#837
@adamralph

Can this line also throw a TargetInvocationException?

Aug 23, 2016
@adamralph

@sharwell OK, so it seems the problem is more deep rooted than this analyzer package, and is in Roslyn itself. Fair enough, I guess enabling docs w…

Aug 23, 2016
@adamralph

See #798, there's some doubt about whether we want to do this.

Aug 23, 2016
@adamralph

Moving back to the backlog, since it seems we're not yet 100% sure that we want to do this.

Aug 23, 2016
@adamralph

Added to 2.3.0 milestone.

Aug 23, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#835
@adamralph

LGTM. Happy to merge after the autosquash 😉

Aug 23, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#835
@adamralph

Is this used for anything?

Aug 22, 2016
@adamralph

Three more items checked off The List in #821: Is dotnet the best moniker to distinguish the new bits? Since the aim is to support the netstand…

Aug 22, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#821
@adamralph

Thanks @blairconrad. Sterling effort!

Aug 22, 2016
@adamralph
Aug 22, 2016
adamralph merged pull request FakeItEasy/FakeItEasy#821
@adamralph
Create a rakefile to build a package with .NET Standard support
5 commits with 447 additions and 24 deletions
Aug 22, 2016
@adamralph

Thanks. Does that mean that I have to enable XML output no matter what, unless I want all sorts of strange effects? It's not really ideal. There's …

Aug 22, 2016
@adamralph

Ahhhh, yes of course. Ruleset files. I keep forgetting that Roslyn analyzers tie in with them. Thanks.

Aug 22, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#821
@adamralph

I did 😄 On 22 Aug 2016 1:57 p.m., "Blair Conrad" notifications@github.com wrote: … and did you see how I created the penultimate commit? — You are…

Aug 22, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#821
@adamralph

LGTM! I think we're ready to squash a few of the commits and merge.

Aug 22, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#821
@adamralph

Given that FakeItEasy.netstd.nuget.targets is recreated during restore, it can indeed be removed and ignored. IMHO there are two things which need …

Aug 22, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#821
@adamralph

It's local, and this is both declaration and assignment: restore_cmd = Exec.new

Aug 22, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#821
@adamralph

There's also an entry in the csproj for this file which will have to be removed: https://github.com/FakeItEasy/FakeItEasy/blob/3756a07a38b2c02347b7…

Aug 22, 2016
adamralph commented on pull request FakeItEasy/FakeItEasy#821
@adamralph

nitpick: this should have a line ending

Aug 22, 2016
@adamralph
Allow configuration of SA0001:XmlCommentAnalysisDisabled
Aug 22, 2016
@adamralph
Allow configuration of SA1311:StaticReadonlyFieldsMustBeginWithUpperCaseLetter
adamralph deleted branch reflecton-reason at adamralph/dude
Aug 21, 2016
Aug 21, 2016
@adamralph