New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"stop" fires for events with falsy duration (oneshot) #3

Closed
adamrenklint opened this Issue Mar 9, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@adamrenklint
Owner

adamrenklint commented Mar 9, 2015

dilla.set('kick', [
  ['1.1.01'], // no "stop" event is fired
  ['1.1.51', null, 0.8] // "stop" even is fired
]);

Should be consistent, fire no `"stop"`` event when duration is falsy (i.e. oneshot)

@adamrenklint adamrenklint changed the title from If duration is falsy, supress "stop" event to "stop" event fires for events with falsy duration Mar 10, 2015

@adamrenklint adamrenklint added bug and removed enhancement question labels Mar 10, 2015

@adamrenklint adamrenklint changed the title from "stop" event fires for events with falsy duration to "stop" fires for events with falsy duration (oneshot) Mar 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment