Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add serie recording support #46

Closed
wants to merge 1 commit into from

Conversation

Glenn-1990
Copy link

As title, schedule serie recordings trough the xbmc GUI.

We also need this:
tvheadend/tvheadend#406

@Glenn-1990
Copy link
Author

schermafdruk van 2014-05-28 01 58 21

schermafdruk van 2014-05-28 01 59 41

htsmsg_add_str(m, "id", id.c_str());

/* Send and wait */
if ((m = m_conn.SendAndWait("deleteDvrAutorecEntry", m, 5)) == NULL)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't hardcode 5 here, there is a setting that defines the timeout that should be used.

@Glenn-1990
Copy link
Author

@Jalle19 @adamsutton , issue with "timer.bIsRepeating" resolved and reworded according the comments :-)

@Jalle19
Copy link
Collaborator

Jalle19 commented Jun 3, 2014

Generally I don't like this at all since we have to custom code the dialog to implement the functionality. XBMC should support series recording (or at least some form of automatic scheduling) through the API, at the moment almost all the addons use this approach and it feels like such a waste of effort. I will hopefully have some time during the summer to sort things out on the XBMC side, but I'll leave it up to @adamsutton to decide what to do with this particular PR.

@Glenn-1990
Copy link
Author

Agreed, it's better to do this on the xbmc side, but that's not possible for Gotham offcource.
I've been waiting for native series support in xbmc for too long , so that's why I came with this :-)
Gotham is the most stable PVR release so far, and will be around for some time, so it would be a very helpfull feature for lots off people. Nowedays, people wanting series support are just switching to another backend..

So, yes it should be handled more generally, but that's someting for Helix I think.
We can also make it a setting defaulting to off or just detect the PVR api from gotham (and disable the feature in Helix).

@CodingFabian
Copy link

can you rebase this change? i would like to try it.

@Glenn-1990 Glenn-1990 closed this Oct 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants