Random improvements #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apart from the few points, looks fine. Main thing to fix is the circbuf change |
This struct is created when the addon is started and stored as a const reference in CTvheadend. This way we avoid having to lock the global mutex whenever a setting value has to be read. It was generally not needed before either since the only time a setting could change was right before the addon was restarted or when the timeout parameters where changed (which didn't require a restart). This removes that uncertainty.
This has worked since every class that uses Tvheadend.h has also had "using namespace ADDON" in it
Jalle19
force-pushed
the
random-improvements
branch
from
8250da3
to
bf8d0db
Compare
|
@adamsutton the |
|
Fair enough. Merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adamsutton @ksooo could you take a look? This is some stuff that I did some time ago but forgot to publish. None of it is really necessary but IMO it makes things a bit leaner.