Incorrect abbreviations for values rounded up #187

Closed
gscottolson opened this Issue Jun 22, 2014 · 0 comments

Projects

None yet

2 participants

@gscottolson

There is a specific case in Numeral where values with abbreviation formats are not rounded up properly to the next abbreviation. There are two test cases I added (locally) that fail to format properly:

...
[999950,'0.0a','1m'],
[999999999,'0.0a','1b'],
...

The above cases will output incorrect abbreviation values:

999950 ⟶ 1000.0k
999999999 ⟶ 1000.0m

The logic around abbreviation bracketing is causing this issue. I tried creating a patch for this, but I couldn’t find a quick solution that didn’t introduce additional test failures.

@adamwdraper adamwdraper added this to the 2.1.0 milestone Dec 21, 2016
@adamwdraper adamwdraper added the bug label Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment