Add an option to strip presenter notes from output #107

Merged
merged 2 commits into from May 5, 2012

Projects

None yet

2 participants

@aaugustin

When publishing a presentation on the web, I prefer not to include my personal notes, because they aren't written for publication.

Of course you're welcome to change the option name and the wording to suit your tastes.

@aaugustin aaugustin Add an option to strip presenter notes from output
Presenter notes often aren't suitable for publication.
cddad98
@adamzap adamzap and 1 other commented on an outdated diff May 4, 2012
src/landslide/main.py
@@ -95,6 +95,13 @@ def _parse_options():
default=False)
parser.add_option(
+ "-P", "--no-presenter-notes",
+ action="store_false",
+ dest="presenter_notes",
+ help="Don't include presenter notes in the output",
+ default=False)
@adamzap
adamzap May 4, 2012 owner

Shouldn't this be default=True?

The tests still pass because you're testing the generator object and the bug is in the option parsing step.

Otherwise this patch looks great.

Thanks

@aaugustin
aaugustin May 4, 2012

Good catch, the default should be True.

@adamzap
Owner
adamzap commented May 5, 2012

Great, thanks!

@adamzap adamzap merged commit 8fd5fee into adamzap:master May 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment