New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compatibility with Python 2.6 #76

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@maraujop

maraujop commented Sep 2, 2011

Flags parameter was added in Python 2.7 This breaks compatibility with Python 2.6 and backwards.

I have tested this with 2.6.4 and it works with my fix.

Regards

maraujop added some commits Sep 2, 2011

RST presenter notes are broken `.note:` key is not regexed correctly.…
… This is a dirty fast fix

RST notes are now done doing:

notes
-----
* blablabla
* blablabla

MD notes:

 # notes
 * blabla
 * blabla
@maraujop

This comment has been minimized.

maraujop commented Sep 3, 2011

Presenter notes are broken

After trying to add presenter notes in a RST file using .note: keyword. I realized depending on many things rst parser generates different contents for the keyword. So I wasn't getting any content in the presenter view notes.

I wanted to do multiline notes, with HTML support. I've done a fast hack, that you might not like, feel free to add support for this as you prefer, because I need a fix asap.

Now RST notes are added doing:

notes
-----
* blablabla
* blablabla

and MD notes:

# notes
* blabla
* blabla

I'm taking for granted notes are the last bits of every slide, so I parse from the title <h1>notes</h1> till the end, I know it's not beautiful.

@maraujop

This comment has been minimized.

maraujop commented Sep 3, 2011

I just realized, after looking at the diff, you changed the way presenter notes are done to the same thing I have done, excepting your heading has to say presenter notes. I didn't even look at the regex as I thought it was broken.

Could you please update the README? I've lost 2 hours playing with this, thanks.

@millette

This comment has been minimized.

millette commented on 1e8ef6a Sep 10, 2011

I think this is a better fix:

            html = re.sub(re.compile(pattern, mode), replacement, html, 0)

because the flags matter, either you're using Python 2.7 or not.

@maraujop

This comment has been minimized.

maraujop commented Sep 10, 2011

You are right, I did it as a fast hack and didn't think about it.

Cheers

@adamzap

This comment has been minimized.

Owner

adamzap commented Sep 16, 2011

I am fixing this with the suggestion by @millette.

Please open a separate pull request for the notes problem.

Thanks!

@adamzap adamzap closed this in dbbf52a Sep 16, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment