[core] CPD: Removed file filter for files that are explicitly specified on the CPD command line using the '--files' command line option. #30

Merged
merged 1 commit into from Jan 20, 2016

Projects

None yet

2 participants

@tiobe
Contributor
tiobe commented Dec 10, 2015

At TIOBE we want to use CPD to check duplicated code for TypeScript and XAML with the built-in Ecmascript and JSP tokenizers. The TypeScript syntax resembles Javascript and XAML files are XML files, just as JSP files.

Unfortunately we cannot use the built-in tokenizers, because CPD rejects the files because the file extensions do not match '.js' or '.jsp'. To fix this problem, I removed the file filter when a user explicit specifies a file name on the CPD command line instead of a directory. I think this is a rare use case, a normal user will specify a directory containing the source files, so it is safe to assume that the user knows what he is doing.

@tiobe tiobe Removed file filter for files that are explicitly specified on the CP…
…D command line using the '--files' command line option.
10db98b
@adangel adangel merged commit 10db98b into adangel:pmd/5.3.x Jan 20, 2016
@adangel
Owner
adangel commented Jan 20, 2016

Thanks!

@tiobe tiobe deleted the tiobe:tiobe/remove_filefilter_for_files branch Feb 18, 2016
@adangel adangel pushed a commit that referenced this pull request Apr 10, 2016
Robert M und David R Added regression test for #30 fafc3a2
@adangel adangel changed the title from Removed file filter for files that are explicitly specified on the CPD command line using the '--files' command line option. to [core] CPD: Removed file filter for files that are explicitly specified on the CPD command line using the '--files' command line option. Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment