Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Python 3.6 #871

Merged
merged 28 commits into from Mar 20, 2022
Merged

Remove support for Python 3.6 #871

merged 28 commits into from Mar 20, 2022

Conversation

danieljanes
Copy link
Member

@danieljanes danieljanes commented Oct 12, 2021 •
edited

Tasks:

  • Remove Python 3.6 PyPI classifier
  • Increase minimum Python version
  • Remove Python 3.6 from CI
  • Remove py36 formatting target
  • Release notes

Fixes #867

@danieljanes danieljanes added this to the 0.18.0 milestone Oct 12, 2021
@tanertopal
Copy link
Member

@danieljanes we will also have to adjust the branch protection rules for the main branch in here: https://github.com/adap/flower/settings/branch_protection_rules right before the merge. Right now its set as required.

@mariaboerner1987 mariaboerner1987 added documentation Improvements or additions to documentation wontfix This will not be worked on labels Dec 17, 2021
@tanertopal
Copy link
Member

@danieljanes I removed the branch protection rule for python 3.6 and added an entry to the changelog

@tanertopal tanertopal removed the wontfix This will not be worked on label Dec 22, 2021
@danieljanes danieljanes added the breaking change This change will introduce break change to the user API. label Jan 6, 2022
@danieljanes danieljanes marked this pull request as ready for review February 28, 2022 18:48
@danieljanes
Copy link
Member Author

@sisco0 any idea why our CI tooling generates lint errors for Python 3.7+ after removing Python 3.6? The lint errors are not present on the main branch.

@sisco0
Copy link
Contributor

sisco0 commented Mar 2, 2022

@danieljanes If you mention this linked action run the errors could be solved by modifying the numpy and mypy versions.

@danieljanes danieljanes enabled auto-merge (squash) March 16, 2022 21:04
@danieljanes danieljanes mentioned this pull request Mar 16, 2022
Merged
@tanertopal tanertopal merged commit 24c8aec into main Mar 20, 2022
@tanertopal tanertopal deleted the rm-py36 branch March 20, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

Assignees

@danieljanes danieljanes

Labels
breaking change This change will introduce break change to the user API. documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

Drop Python 3.6 Support
4 participants
@danieljanes @tanertopal @sisco0 @mariaboerner1987