Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Embedding Documentation #706

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Conversation

hSterz
Copy link
Member

@hSterz hSterz commented Jun 3, 2024

Improve Embedding Documentation (#643 ) by:

  • Adding an example notebook
  • Updating the embedding page in the documentation

@hSterz hSterz marked this pull request as ready for review June 4, 2024 14:25
@calpt calpt linked an issue Jun 8, 2024 that may be closed by this pull request
docs/embeddings.md Show resolved Hide resolved
docs/embeddings.md Show resolved Hide resolved
notebooks/Adapter_With_Embeddings.ipynb Show resolved Hide resolved
Copy link
Contributor

@TimoImhof TimoImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I fixed a few minor typos. With the requested changes incorporated, this is ready to go!

@TimoImhof TimoImhof merged commit 3c2e702 into adapter-hub:main Jun 24, 2024
dainis-boumber added a commit to ReDASers/adapters that referenced this pull request Aug 23, 2024
Improve Embedding Documentation (adapter-hub#643 ) by:
- Adding an example notebook
- Updating the embedding page in the documentation

---------

Co-authored-by: calpt <calpt@mail.de>
Co-authored-by: Timo Imhof <timo.imhof.uni@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better embeddings documentation.
3 participants