Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/3204 Added check for _isTrackable and skip bug warn for missing components #218

Merged
merged 3 commits into from Jul 21, 2021
Merged

issue/3204 Added check for _isTrackable and skip bug warn for missing components #218

merged 3 commits into from Jul 21, 2021

Conversation

oliverfoster
Copy link
Member

fxies adaptlearning/adapt_framework#3204

Added

  • Check for _isTrackable: false
  • Warn for missing components rather than fail

@oliverfoster oliverfoster self-assigned this Jul 21, 2021
@oliverfoster oliverfoster added this to New in adapt_framework: The TODO Board via automation Jul 21, 2021
@oliverfoster oliverfoster moved this from New to Needs reviewing in adapt_framework: The TODO Board Jul 21, 2021
danielghost
danielghost approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@danielghost danielghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolves the setAttemptObject error.

tomgreenfield
tomgreenfield approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit b30c5e9 into master Jul 21, 2021
adapt_framework: The TODO Board automation moved this from Needs reviewing to Needs releasing Jul 21, 2021
@oliverfoster oliverfoster deleted the issue/3204 branch July 21, 2021 15:00
@oliverfoster oliverfoster removed this from Needs releasing in adapt_framework: The TODO Board Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomgreenfield tomgreenfield tomgreenfield approved these changes

@danielghost danielghost danielghost approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@eleanor-heath eleanor-heath Awaiting requested review from eleanor-heath

Assignees

@oliverfoster oliverfoster

Labels
bug high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oliverfoster @tomgreenfield @danielghost @cahirodoherty-learningpool