Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow navigation elements to be controlled via the JSON #1555

Open
moloko opened this Issue May 9, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@moloko
Copy link
Member

moloko commented May 9, 2017

It seems that there's quite a few things to do with the nav buttons you can't currently change without editing the theme, which isn't ideal even for Framework users and particularly not for Authoring Tool users.

For example, one of our course builders commented:

For example on one page modules where the home button is stuck at the top left and it’s not needed. You can’t turn it off without [front end developer] input, so would be good to configure it in the json

Also see this forum post

@oliverfoster

This comment has been minimized.

Copy link
Member

oliverfoster commented May 9, 2017

We need a huddle on this. There are some fundamental bits about the navigation api that need sorting out.... i.e. there currently isn't one.

@moloko

This comment has been minimized.

Copy link
Member Author

moloko commented May 10, 2017

@oliverfoster definitely. there's also quite a lot of possible combinations of setup to consider as well I fear.

@barryo-learningpool

This comment has been minimized.

Copy link
Contributor

barryo-learningpool commented Jul 24, 2017

From @oliverfoster:

We also need a left, right, center + order for the navigation bar.

@barryo-learningpool

This comment has been minimized.

Copy link
Contributor

barryo-learningpool commented Jul 25, 2017

I'm happy to work on this if we can get some kind of spec going

@barryo-learningpool

This comment has been minimized.

Copy link
Contributor

barryo-learningpool commented Jul 25, 2017

@oliverfoster I assume with left, right and center you mean where the navigation bar appears in the header?

BTW, the only navigation buttons I've found so far are back, home and drawer toggle. At the moment "Home" only seems to appear if the theme defines it (it is not in the core navigation.hbs). Have I got this right?

@oliverfoster

This comment has been minimized.

Copy link
Member

oliverfoster commented Jul 25, 2017

I meant that the items in the navigation bar need a left, right, center + order + visibility.
I'm not so worried about the placement of the navigation bar.

It would be nice if we had an API for registering navigation bar icons/graphics/text items and their actions, much like the drawer.
That API should include something close to:

  • Allowing an extension to add and remove an icon/text item/graphic
  • Position the item left, right or center
  • Order the item within its position
  • Add an item tool-tip
  • Handle the item's mouse events
@chucklorenz

This comment has been minimized.

Copy link
Member

chucklorenz commented Mar 16, 2018

Some code to be had here:
https://github.com/cgkineo/adapt-backButton
https://github.com/cgkineo/adapt-homeButton

l'd also like to see navigation be constructed to make use of flexbox, now that we've abandoned legacy browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.