Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Cache management for subsequent compilation improvements (fixes #3363) #3364

Merged
merged 2 commits into from Mar 1, 2023
Merged

New: Cache management for subsequent compilation improvements (fixes #3363) #3364

merged 2 commits into from Mar 1, 2023

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 11, 2023 •
edited

fixes #3363

New

  • Allow adapt_framework to store javascript compilation cache files in the operating system temp folder, cleaning up files, once a day, if they are older than a week. Reduces subsequent compilation times sustantially. Initial compilation remains unchanged. Files are cached in $TMPDIR/adapt_framework/.

@oliverfoster oliverfoster self-assigned this Feb 11, 2023
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 95fa6b0 into master Mar 1, 2023
@oliverfoster oliverfoster deleted the issue/3363 branch March 1, 2023 16:08
github-actions bot pushed a commit that referenced this pull request Mar 1, 2023
@semantic-release-bot
Chore(release): 5.27.0 [skip ci]
99a1226 
# [5.27.0](v5.26.1...v5.27.0) (2023-03-01)

### Fix

* Bump json5 from 1.0.1 to 1.0.2 (#3355) ([59aed64](59aed64)), closes [#3355](#3355)

### New

* Cache management for subsequent compilation improvements (fixes #3363) (#3364) ([95fa6b0](95fa6b0)), closes [#3363](#3363) [#3364](#3364)
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

🎉 This PR is included in version 5.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StuartNicholls StuartNicholls StuartNicholls approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@taylortom taylortom Awaiting requested review from taylortom

Assignees

@oliverfoster oliverfoster

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential performance compilation improvement
4 participants
@oliverfoster @StuartNicholls @cahirodoherty-learningpool @eleanor-heath