New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-1156-1157: added handlebars to core #1158

Merged
merged 3 commits into from Jul 27, 2016

Conversation

Projects
None yet
5 participants
@oliverfoster
Member

oliverfoster commented Jul 25, 2016

part of #954

this is one of the least contentious parts of moving some of the theme foundations into core

#1156

@oliverfoster oliverfoster self-assigned this Jul 25, 2016

@tomgreenfield

This comment has been minimized.

Show comment
Hide comment
@tomgreenfield

tomgreenfield Jul 25, 2016

Contributor

Time to remove the redundant maintainers comments?

Contributor

tomgreenfield commented Jul 25, 2016

Time to remove the redundant maintainers comments?

@oliverfoster

This comment has been minimized.

Show comment
Hide comment
@oliverfoster
Member

oliverfoster commented Jul 25, 2016

done

@tomgreenfield

This comment has been minimized.

Show comment
Hide comment
@tomgreenfield

tomgreenfield Jul 25, 2016

Contributor

+1

Contributor

tomgreenfield commented Jul 25, 2016

+1

@lc-thomasberger

This comment has been minimized.

Show comment
Hide comment
@lc-thomasberger
Member

lc-thomasberger commented Jul 25, 2016

+1

@guywillis

This comment has been minimized.

Show comment
Hide comment
@guywillis

guywillis Jul 26, 2016

Contributor

+1

Contributor

guywillis commented Jul 26, 2016

+1

@andrewhosgood

This comment has been minimized.

Show comment
Hide comment
@andrewhosgood

andrewhosgood Jul 26, 2016

Contributor

Will there now be another way to change the markup for a specific theme without modifying the core or is this no longer possible?

Contributor

andrewhosgood commented Jul 26, 2016

Will there now be another way to change the markup for a specific theme without modifying the core or is this no longer possible?

@oliverfoster

This comment has been minimized.

Show comment
Hide comment
@oliverfoster

oliverfoster Jul 26, 2016

Member

you can still override any handlebars from the theme in the same way we do at the moment @andrewhosgood

the idea of this is to make a theme more about themeing and less about structure, to better support all of the core theme variables out of the box, and to provide a set of architectural layers for themeing. we should be able to get more innovation for less work, once this and a series of other PRs are in.

Member

oliverfoster commented Jul 26, 2016

you can still override any handlebars from the theme in the same way we do at the moment @andrewhosgood

the idea of this is to make a theme more about themeing and less about structure, to better support all of the core theme variables out of the box, and to provide a set of architectural layers for themeing. we should be able to get more innovation for less work, once this and a series of other PRs are in.

@oliverfoster oliverfoster merged commit 8ef54d8 into master Jul 27, 2016

@brian-learningpool brian-learningpool deleted the issue-1156 branch Aug 11, 2016

oliverfoster added a commit that referenced this pull request Dec 12, 2017

Feature/1189 less enhancements (#1897)
* correct email addresses for himanshu and aniket

* issue-1163: moved vanilla font into core (#1165)

* issue-1163: moved vanilla font into core

* issue-1163: removed redundant fonts

* issue-1164: moved theme common assets to core (#1166)

* issue-1160: expand less compiler for core (#1161)

* issue-1156-1157: added handlebars to core (#1158)

* issue-1156-1157: added handlebars to core

* issue-1156-1157: removed handlebars comments

* issue-1156-1157: removed buttons.hbs partial

* issue-1167: fix bug in create-json-config (#1168)

* issue-1051: added accessibility helpers (#1170)

* issue-1051: added accessibility helpers

* issue-1051: force spaces for attributes

* issue-1051: removed unnecessary a11y-ignore-focus

* issue-1159: add screenSize from theme to less (#1162)

* issue-1159: add screenSize from theme to less

* issue-1159: tabs > spaces

* issue-1159: tabs > spaces

* Issue-1159: changed console log

* Issue-1159: changed console log

* Fix indentation

* issue-1183: order of less compile, variables first

* issue-1185: make core assets theme relative (#1186)

* issue-1187: matching partial feedback fix (#1188)

* issue-1187: matching partial feedback fix

setupFeedback should be called through the view always in compatibility mode as some of its sub functions can live on the view only

* issue-1187: matching partial feedback fix

* Corrected Himanshu's email

* Less Enhancements

* Less Enhancements

* Less Enhancements

* Less Enhancements

* 1. Changed the folder structure
2. Normalized the code
3. Optimized Code
4. Shifted the Code to related files
5. Added new files direction.less, marking.less, notify-push.less to segregate the code
6. Rename file names paddings.less to spacings.less
7. Removed theme Dependency
8. Minor changes in the grunt tasks

* 1189 -- Less-Enhancements

* Amends implemented based on feedback from Guy

• Amend @item-color-hover and @button-hover-color to use secondary hex
value instead of variable in compatibility.less
• Update the disabled mixin in buttons.less (global) to the following:
o &.disabled { .disabled-style; }
o &:disabled { .disabled-style; }
o // IE8 fix needed to be in its own line
o &[disabled="disabled"] { .disabled-style; }
• Remove top CSS declaration from accessibility common mixin and move to
#a11y-focuser in accessibility.less
• Add bottom: 0; to #a11y-focusguard in accessibility.less
• Add bottom: 0; to #a11y-selected in accessibility.less
• Add RTL styles to button margins in buttons.less (modules)
• Remove RTL styles from .loading in loading.less
• Remove RTL styles from .notify-shadow in notify.less
• Move .component-container so it’s not nested under .block-inner in
block.less
• Remove .background-color-inverted from .block.less
• Remove component title / body inner padding CSS attributes in
component.less
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment