Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/3180 Update babel-plugin-transform-amd-to-es6 #3181

Merged
merged 1 commit into from Jun 29, 2021
Merged

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Jun 21, 2021

fixes #3180

Updated

Test

  • Add adapt-chartjs to your project, the umd library js/Chart.min should transpile correctly

@oliverfoster oliverfoster self-assigned this Jun 21, 2021
@oliverfoster oliverfoster added this to New in Bugs via automation Jun 21, 2021
@oliverfoster oliverfoster moved this from New to Needs reviewing in Bugs Jun 21, 2021
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@chrisgillison
Copy link

Have tested this with chartjs version 0.0.2 & a modified Framework 5.14.0 package.json. Working fine for me.

Copy link

@ethan-lp ethan-lp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@tomgreenfield tomgreenfield merged commit f15edf2 into master Jun 29, 2021
Bugs automation moved this from Needs reviewing to Needs releasing Jun 29, 2021
@tomgreenfield tomgreenfield deleted the issue/3180 branch June 29, 2021 10:52
@oliverfoster oliverfoster added this to New in Infrastructure via automation Jun 29, 2021
@oliverfoster oliverfoster moved this from New to Needs releasing in Infrastructure Jun 29, 2021
@oliverfoster oliverfoster added this to New in adapt_framework: The TODO Board via automation Jun 29, 2021
@oliverfoster oliverfoster moved this from New to Needs releasing in adapt_framework: The TODO Board Jun 29, 2021
@oliverfoster oliverfoster removed this from Needs releasing in adapt_framework: The TODO Board Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Bugs
Needs releasing
Infrastructure
Needs releasing
Development

Successfully merging this pull request may close these issues.

adapt_framework: typeof undefined with UMD modules
5 participants