tsify more addons modules #1661
Conversation
| } | ||
|
|
||
| export default function ImageFormatter({ value }: Props) { | ||
| return <div className="react-grid-image" style={{ backgroundImage: `url(${value})` }} />; |
There was a problem hiding this comment.
The previous ImageFormatter implementation loaded the url in the background before applying the style, I don't know why, doesn't seem worthwhile.
|
|
||
| render() { | ||
| return ( | ||
| <ContextMenu identifier="reactDataGridContextMenu"> |
There was a problem hiding this comment.
Bug uncovered: identifier is not a valid prop, id is though.
nstepien
changed the title
packages/react-data-grid-addons/src/cells/headerCells/filters/NumericFilter.tsx
Outdated
Show resolved
Hide resolved
| <div> | ||
| <div style={columnStyle}> | ||
| <input | ||
| key={inputKey} |
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input
If this attribute is not specified, the default type adopted is
text.
I can add it, but it's not necessary. wdyt?
There was a problem hiding this comment.
I usually prefer to add it to be explicit but it is fine in this case
|
|
||
| // implement default filter logic | ||
| const value = parseInt(row[columnKey] as string, 10); | ||
| for (const ruleKey in columnFilter.filterTerm) { |
There was a problem hiding this comment.
for (const rule of columnFilter.filterTerm)
There was a problem hiding this comment.
It's not an iterable.
There was a problem hiding this comment.
Ah, I got confused with filterTerm: Rule[] | null;
No description provided.