diff --git a/src/JsEngine.cpp b/src/JsEngine.cpp index a2bcf9a4..621df56e 100644 --- a/src/JsEngine.cpp +++ b/src/JsEngine.cpp @@ -25,14 +25,14 @@ namespace { - v8::Handle CompileScript(v8::Isolate* isolate, + v8::Local CompileScript(v8::Isolate* isolate, const std::string& source, const std::string& filename) { using AdblockPlus::Utils::ToV8String; - const v8::Handle v8Source = ToV8String(isolate, source); + const v8::Local v8Source = ToV8String(isolate, source); if (filename.length()) { - const v8::Handle v8Filename = ToV8String(isolate, filename); + const v8::Local v8Filename = ToV8String(isolate, filename); return v8::Script::Compile(v8Source, v8Filename); } else @@ -191,7 +191,7 @@ AdblockPlus::JsValue AdblockPlus::JsEngine::Evaluate(const std::string& source, { const JsContext context(*this); const v8::TryCatch tryCatch(GetIsolate()); - const v8::Handle script = CompileScript(GetIsolate(), source, + const v8::Local script = CompileScript(GetIsolate(), source, filename); CheckTryCatch(tryCatch); v8::Local result = script->Run(); diff --git a/src/JsError.cpp b/src/JsError.cpp index 3af341f1..3c5565a8 100644 --- a/src/JsError.cpp +++ b/src/JsError.cpp @@ -19,14 +19,14 @@ using namespace AdblockPlus; -JsError::JsError(const v8::Handle& exception, - const v8::Handle& message) +JsError::JsError(const v8::Local& exception, + const v8::Local& message) : std::runtime_error(ExceptionToString(exception, message)) { } -std::string JsError::ExceptionToString(const v8::Handle& exception, - const v8::Handle& message) +std::string JsError::ExceptionToString(const v8::Local& exception, + const v8::Local& message) { std::stringstream error; error << *v8::String::Utf8Value(exception); diff --git a/src/JsError.h b/src/JsError.h index be45d092..39557119 100644 --- a/src/JsError.h +++ b/src/JsError.h @@ -27,10 +27,10 @@ namespace AdblockPlus class JsError : public std::runtime_error { public: - JsError(const v8::Handle& exception, - const v8::Handle& message); - static std::string ExceptionToString(const v8::Handle& exception, - const v8::Handle& message); + JsError(const v8::Local& exception, + const v8::Local& message); + static std::string ExceptionToString(const v8::Local& exception, + const v8::Local& message); }; } diff --git a/src/JsValue.cpp b/src/JsValue.cpp index 3934cc18..c7c2aab6 100644 --- a/src/JsValue.cpp +++ b/src/JsValue.cpp @@ -25,7 +25,7 @@ using namespace AdblockPlus; AdblockPlus::JsValue::JsValue(AdblockPlus::JsEnginePtr jsEngine, - v8::Handle value) + v8::Local value) : jsEngine(jsEngine), value(new v8::Global(jsEngine->GetIsolate(), value)) { @@ -188,7 +188,7 @@ AdblockPlus::JsValue AdblockPlus::JsValue::GetProperty(const std::string& name) return JsValue(jsEngine, obj->Get(property)); } -void AdblockPlus::JsValue::SetProperty(const std::string& name, v8::Handle val) +void AdblockPlus::JsValue::SetProperty(const std::string& name, v8::Local val) { if (!IsObject()) throw std::runtime_error("Attempting to set property on a non-object"); @@ -246,7 +246,7 @@ std::string AdblockPlus::JsValue::GetClass() const JsValue JsValue::Call(const JsValueList& params) const { const JsContext context(*jsEngine); - std::vector> argv; + std::vector> argv; for (const auto& param : params) argv.push_back(param.UnwrapValue()); @@ -258,7 +258,7 @@ JsValue JsValue::Call(const JsValueList& params, const JsValue& thisValue) const const JsContext context(*jsEngine); v8::Local thisObj = v8::Local::Cast(thisValue.UnwrapValue()); - std::vector> argv; + std::vector> argv; for (const auto& param : params) argv.push_back(param.UnwrapValue()); @@ -269,13 +269,13 @@ JsValue JsValue::Call(const JsValue& arg) const { const JsContext context(*jsEngine); - std::vector> argv; + std::vector> argv; argv.push_back(arg.UnwrapValue()); return Call(argv, context.GetV8Context()->Global()); } -JsValue JsValue::Call(std::vector>& args, v8::Local thisObj) const +JsValue JsValue::Call(std::vector>& args, v8::Local thisObj) const { if (!IsFunction()) throw std::runtime_error("Attempting to call a non-function"); diff --git a/src/Utils.cpp b/src/Utils.cpp index 2eeb8d1c..b084ffba 100644 --- a/src/Utils.cpp +++ b/src/Utils.cpp @@ -26,7 +26,7 @@ using namespace AdblockPlus; -std::string Utils::FromV8String(const v8::Handle& value) +std::string Utils::FromV8String(const v8::Local& value) { v8::String::Utf8Value stringValue(value); if (stringValue.length()) @@ -35,7 +35,7 @@ std::string Utils::FromV8String(const v8::Handle& value) return std::string(); } -StringBuffer Utils::StringBufferFromV8String(const v8::Handle& value) +StringBuffer Utils::StringBufferFromV8String(const v8::Local& value) { v8::String::Utf8Value stringValue(value); if (stringValue.length()) diff --git a/src/Utils.h b/src/Utils.h index 0f9dfb16..f68780e3 100644 --- a/src/Utils.h +++ b/src/Utils.h @@ -31,8 +31,8 @@ namespace AdblockPlus { namespace Utils { - std::string FromV8String(const v8::Handle& value); - StringBuffer StringBufferFromV8String(const v8::Handle& value); + std::string FromV8String(const v8::Local& value); + StringBuffer StringBufferFromV8String(const v8::Local& value); v8::Local ToV8String(v8::Isolate* isolate, const std::string& str); v8::Local StringBufferToV8String(v8::Isolate* isolate, const StringBuffer& bytes); void ThrowExceptionInJS(v8::Isolate* isolate, const std::string& str);