Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollLock is not working. (And I have two scrollbars) #160

Closed
GustavPS opened this issue Dec 29, 2014 · 5 comments
Closed

scrollLock is not working. (And I have two scrollbars) #160

GustavPS opened this issue Dec 29, 2014 · 5 comments

Comments

@GustavPS
Copy link

Hi there! I can't get scrollLock to work. I have this in jquery:

$(document).ready(function() {
(function($) {
$(document).ready(function() {
$.slidebars({
scrollLock: false
});
});
}) (jQuery);

I tried to do "siteClose: true" and that works but I can't get scrollLock to work, even if I add it I can still scroll. Im I retarded here or is this a bug?

I also noticed that I have a problem with a double scroll bar.

EDIT: I am also using the newest version.
EDIT: I got the scrollLock working by switching to version 10.0.1 so I guess it's something wrong with v 10.0.2. I still got the problem with two scrollbars though,

@GustavPS GustavPS changed the title scrollLock is not working. scrollLock is not working. (And I have two scrollbars) Dec 29, 2014
@GustavPS
Copy link
Author

Nevermind, I fixed it myself. The scrollbar problem was a problem on my end.

NOTE TO CREATOR: I fixed the scrollLock by changing this on the css:

html.sb-scroll-lock.sb-active:not(.sb-static) {
overflow: hidden;
}

to:

html.sb-scroll-lock.sb-active:not(.sb-static),
html.sb-scroll-lock.sb-active:not(.sb-static) body {
overflow: hidden;
height: 100%;
}

@adchsm
Copy link
Owner

adchsm commented Dec 30, 2014

Thanks for letting me know. On iOS though, if you have scrolled down the page where minimal ui kicks in, changing the body height to 100% will cause the screen size to change, reverting back to a non-minimal ui, the behavior is wierd.

At the moment, I'm not developing Slidebars, but I'm considering dropping minimal ui support in the future.

Thanks, Adam

@GustavPS
Copy link
Author

Okey, but I got one more question, Is it possible to do this on worpress? Im currently converting my website (HTML & CSS) to wordpress

@szyam
Copy link

szyam commented Jan 3, 2015

@97gupe30 You can definitely use in WP. WP is really no different from a standard php site, you can usually use any css or jquery you like.

@adchsm
Copy link
Owner

adchsm commented Jan 5, 2015

Yep as @szyam said, its definately possible in WordPress.

For example, you'll want to add the scripts and styles using wp_enqueue_scripts.

Then, you might want your opening sb-site div in header.php and the closing tag for this in footer.php. Also in footer.php you may want your Slidebars markup <div class="sb-slidebar sb-left"> etc.

You could then add content to the Slidebars by adding menus and widgetized sidebars.

I hope that helps,

Thanks, Adam

@adchsm adchsm closed this as completed Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants