docs: add MIGRATION_v5_to_v6 stub + trigger 6.0.0-beta.1 release-please bump (refs #802)#823
Merged
Merged
Conversation
Mirrors the precedent set by MIGRATION_v1_to_v2 / v3_to_v4 / v4.0_to_v4.1 — a per-major migration doc that accretes entries as breaking surfaces land on the beta line (starting with #741 canonical-formats). Also serves as the Release-As trigger for the initial 6.0.0-beta.1 bump, since the original trailer on #804 was buried mid-message by the squash-merge and release-please's parser only honors footers at the very end of a commit message. Refs: #802 Release-As: 6.0.0-beta.1
![aao-ipr-bot[bot]](https://avatars.githubusercontent.com/u/134922?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM. Doc stub mirrors precedent; Release-As: trailer is correctly anchored at end-of-message this time.
Things I checked
- Precedent claim:
MIGRATION_v1_to_v2.md,MIGRATION_v3_to_v4.md,MIGRATION_v4.0_to_v4.1.mdall present; new stub matches their shape. - Footer position:
Release-As: 6.0.0-beta.1is the final non-empty line of the commit body on0ad5c920. release-please only honors trailers at end-of-message — exactly the fix for the buried trailer on #804 /fc5ee16b. release-please-config.json:release-type: python,prerelease: true,prerelease-type: beta. Native Python updater handles SemVer → PEP 440 (6.0.0-beta.1→6.0.0b1), matching checklist item 2.- Docs-only diff (one new file, 42 lines, no source). Skip-everything triage — no
code-revieweror domain experts. - Content squares with the
ADCP_VERSIONinvariant: SDK package version and upstream protocol version stay independent.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two things in one tiny PR:
MIGRATION_v5_to_v6.mdstub — mirrors the precedent set by the existingMIGRATION_*.mdfiles. Will accrete per-release sections as breaking surfaces (canonical-formats feat(canonical-formats): Pythonic v1↔v2 projection layer — parallel to adcp-client #1815 #741, etc.) land on the beta line. The aao-ipr-bot flagged this as a non-blocking follow-up on chore: configure release-please for 6.0.0-beta line (closes #802) #804.Release-As: 6.0.0-beta.1trailer at the very end of the commit message. The original trailer on chore: configure release-please for 6.0.0-beta line (closes #802) #804 was buried mid-message by the squash-merge (between the original commit body and the fix-up commit's body), so release-please's parser didn't pick it up — the release-please run onfc5ee16breported "PR chore(main): release 6.0.0-beta.1 #817 remained the same" and kept proposing 5.7.1. This commit's clean trailer at end-of-message triggers the bump.Verify after merge
pyproject.tomlversion is6.0.0b1(PEP 440 form). The previous PR (chore: configure release-please for 6.0.0-beta line (closes #802) #804) dropped theextra-filesJSON writer so the Python release-type's native updater should now apply the SemVer → PEP 440 conversion correctly.If the release PR still shows 5.7.x: release-please ran but didn't see the trailer. Try closing PR #817 manually to force re-creation.
🤖 Generated with Claude Code