show a message for empty feeds #213

Merged
merged 8 commits into from Jan 5, 2017

Projects

None yet

3 participants

@p0o
Collaborator
p0o commented Dec 31, 2016

This PR should show a message for empty feeds

@p0o p0o added the waiting-review label Dec 31, 2016
@adcpm adcpm temporarily deployed to busy6-pr-213 Dec 31, 2016 Inactive
@adcpm
Owner
adcpm commented Dec 31, 2016

Actually the "empty feed message" will appear on Bookmark and user profile too. We need a way to handle custom message for these pages.

@p0o
Collaborator
p0o commented Dec 31, 2016

@adcpm shouldn't be a problem. What kind of messages we need for these pages?

@adcpm
Owner
adcpm commented Dec 31, 2016 edited

@p0o There is already an empty message on bookmark page, you can keep same text. About user profile i would see a different message if you its your profile you are visiting or if its another user profile. My profile the message could be : "You didn't publish any story yet. Start now" and another user "This user don't have any story published yet."

@p0o p0o removed the waiting-review label Jan 1, 2017
@adcpm adcpm temporarily deployed to busy6-pr-213 Jan 2, 2017 Inactive
@p0o
Collaborator
p0o commented Jan 2, 2017

@adcpm should work as expected

@p0o p0o added the waiting-review label Jan 2, 2017
src/user/UserFeed.js
- loadMoreContent={loadMoreContentAction}
- route={this.props.route}
- />
+ <di>
@nil1511
nil1511 Jan 2, 2017 Collaborator

I think It should be div. 😄

@p0o
p0o Jan 2, 2017 Collaborator

@nil1511 Hahaha, right 😄

src/feed/Feed.js
@@ -1,4 +1,5 @@
import React from 'react';
@nil1511
nil1511 Jan 2, 2017 Collaborator

This file changes can be cleared.

@adcpm adcpm temporarily deployed to busy6-pr-213 Jan 2, 2017 Inactive
@adcpm adcpm temporarily deployed to busy6-pr-213 Jan 2, 2017 Inactive
@p0o
Collaborator
p0o commented Jan 2, 2017

@nil1511 thank you, should be okay now.

@nil1511
nil1511 approved these changes Jan 2, 2017 View changes
@adcpm
Owner
adcpm commented Jan 2, 2017

@p0o Empty message is visible on user profile while posts are fetching.

@p0o
Collaborator
p0o commented Jan 3, 2017

@adcpm thank you. It's fixed now.

@adcpm adcpm requested a deployment to busy6-pr-213 Jan 5, 2017 Pending
@adcpm adcpm merged commit ee38e76 into dev Jan 5, 2017
@adcpm adcpm deleted the page branch Jan 5, 2017
@nil1511 nil1511 removed the waiting-review label Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment