From 485a6ef33eb3c6b3ca2576e1d886d45e7a26e0ee Mon Sep 17 00:00:00 2001 From: Ashok Lama Date: Thu, 18 May 2023 13:27:43 +0545 Subject: [PATCH] Fix unclosed HTML element issue - Fix: Unclosed HTML element caused by improperly defined attribute `data-wishlist_id` of add to wishlist button. [GitHub Issue #348](https://github.com/addonify/addonify-wishlist/issues/348) --- README.txt | 1 + public/class-addonify-wishlist-public.php | 2 +- public/templates/addonify-add-to-wishlist-button.php | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/README.txt b/README.txt index d6c01dc..d3a9740 100644 --- a/README.txt +++ b/README.txt @@ -146,6 +146,7 @@ You can use this `[addonify_wishlist]` shortcode to display the wishlist table i - Removed: Added to cart popup modal displayed when product is added to cart in wishlist page. - Tweak: Popup modal now closes when clicked on modal overlay. - Fix: Issue of product stock status not getting displaying in wishlist sidebar when a product is added into the wishlist. [GitHub Issue #344](https://github.com/addonify/addonify-wishlist/issues/344) +- Fix: Unclosed HTML element caused by improperly defined attribute `data-wishlist_id` of add to wishlist button. [GitHub Issue #348](https://github.com/addonify/addonify-wishlist/issues/348) = 2.0.1 - 15 May, 2023 = diff --git a/public/class-addonify-wishlist-public.php b/public/class-addonify-wishlist-public.php index 5b583f5..04e141e 100644 --- a/public/class-addonify-wishlist-public.php +++ b/public/class-addonify-wishlist-public.php @@ -572,7 +572,7 @@ public function render_add_to_wishlist_button_single() { if ( addonify_wishlist_get_option( 'btn_position_on_single' ) === 'before_add_to_cart_form' || - addonify_wishlist_get_option( 'btn_position_on_single' ) === 'adter_add_to_cart_form' + addonify_wishlist_get_option( 'btn_position_on_single' ) === 'after_add_to_cart_form' ) { echo ''; } diff --git a/public/templates/addonify-add-to-wishlist-button.php b/public/templates/addonify-add-to-wishlist-button.php index cafec1e..f84715a 100644 --- a/public/templates/addonify-add-to-wishlist-button.php +++ b/public/templates/addonify-add-to-wishlist-button.php @@ -26,7 +26,7 @@ $wishlist = ''; $button_label_preserved = ''; if ( isset( $parent_wishlist_id ) ) { - $wishlist = 'data-wishlist_id=' . $parent_wishlist_id; + $wishlist = 'data-wishlist_id="' . $parent_wishlist_id . '"'; } else { $parent_wishlist_id = ''; }