This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
do not swallow exceptions for disk checks #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`WriteableDiskCheck` can fail for a variety of reasons besides the underlying `open` or `utimensat` syscalls failing. For example: another directory (such as `/bin` or `/lib`) can not be read, a shared library could be missing, a ulimit reached, or a bug in the check itself. To allow those situations to be debugged we need to exception. NOTE: Log is at WARN to preserve 'at least one path must be writeable' semantics. However, those semantics are nuts and should probably be changed to 'all paths must be writeable'.
|
Are you sure those cases all throw exceptions? I would expect at least a few of them to manifest as non-zero exit values for the |
|
Can we revisit this? It looks like this pull request is better than the current behavior which is to drop exceptions on the floor. |
|
mspiegel
pushed a commit
that referenced
this pull request
Feb 20, 2015
Addresses the issues that were brought up in #131
mspiegel
pushed a commit
that referenced
this pull request
Mar 4, 2015
Addresses the issues that were brought up in #131. Add a wrapper class that executes child processes. Does not attempt to consume from standard output or standard error. Kills the child process if the child is blocking on the output streams. This is preferred for our use cases where the alternative is to create an extra thread to consume from these streams.
|
This has been superseded by #151 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WriteableDiskCheckcan fail for a variety of reasons besides theunderlying
openorutimensatsyscalls failing. For example:another directory (such as
/binor/lib) can not be read, ashared library could be missing, a ulimit reached, or a bug in the
check itself. To allow those situations to be debugged we need to
exception.
NOTE: Log is at WARN to preserve 'at least one path must be writeable'
semantics. However, those semantics are nuts and should probably be
changed to 'all paths must be writeable'.