Todo View file is called todos.js #196

Closed
stuartmemo opened this Issue Oct 20, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@stuartmemo
Contributor

stuartmemo commented Oct 20, 2012

I found this filename slightly confusing because of its pluralisation. Made me think that this view handled all the todo items as one. All other similar files in the project don't have the 's' on the end.

Thoughts?

@addyosmani

This comment has been minimized.

Show comment Hide comment
@addyosmani

addyosmani Oct 20, 2012

Owner

Happy to adjust the filename to avoid confusion. Would you like to file a quick PR with the change (e.g todo.js or todoItem.js)? :)

Owner

addyosmani commented Oct 20, 2012

Happy to adjust the filename to avoid confusion. Would you like to file a quick PR with the change (e.g todo.js or todoItem.js)? :)

@stuartmemo

This comment has been minimized.

Show comment Hide comment
@stuartmemo

stuartmemo Oct 20, 2012

Contributor

No probs! Done!

Contributor

stuartmemo commented Oct 20, 2012

No probs! Done!

@addyosmani

This comment has been minimized.

Show comment Hide comment
@addyosmani

addyosmani Oct 21, 2012

Owner

Fixed.

Owner

addyosmani commented Oct 21, 2012

Fixed.

@addyosmani addyosmani closed this Oct 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment