Be more clear about Model.attributes and Model.toJSON #212

merged 1 commit into from Nov 9, 2012


None yet
2 participants

xMartin commented Nov 9, 2012

I moved the explanation of Model.attributes down in the order and removed the example completely. I think there shouldn't be so many references to something that's not encouraged to be used. Also I found out some details about the toJSON method and tried to make the explanation more clear. As passing the result of a toJSON call to JSON.stringify contradicts this explanation I removed it from the example. Don't think it's needed anyway.

Additionally I fixed the heading structure in the models section.


addyosmani commented Nov 9, 2012

Nice work, @xMartin. I appreciate the PR. I agree that we shouldn't be highlighting a feature that isn't recommended. This looks good to merge. Please feel free to let me know if there are any other suggestions/pull requests you have for improvements. Cheers!

@addyosmani addyosmani added a commit that referenced this pull request Nov 9, 2012

@addyosmani addyosmani Merge pull request #212 from xMartin/model-improvements
Be more clear about Model.attributes and Model.toJSON

@addyosmani addyosmani merged commit b034603 into addyosmani:gh-pages Nov 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment