Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Complete rewritten Mobile chapter, 2nd pull request #377

Closed
wants to merge 62 commits into from

4 participants

@raDiesle

Complete rewritten Mobile chapter, 2nd pull request,
first, #315

@addyosmani
Owner

cc @dcmaf - thank you so much for the second pull, @raDiesle

and others added some commits
@addyosmani For #342 - some improvements, adding in nested models/collections piece 669ad54
@addyosmani For #342 - simplifying what does mvc give us summary a5592b4
@addyosmani For #342 - addressing further feedback 637650d
@addyosmani For #342 - first take at improving mvc applied to the web 1d253fc
@addyosmani For #342 - lots of updates to the mvc in the browser/client-side mvc …
…section
4dcc717
@addyosmani For #342 - updates model paragraph 7e69a99
@addyosmani For #342 - updates validation in internals 5b51682
@addyosmani Fixes #322 - adds more details about yeoman with differences between …
…it and bbb. Also added a mention of backbone devtools for kicks
a27605d
@raDiesle raDiesle several layouting corrections, small enhancements, adaption of image …
…sizing
1a801de
@addyosmani For #387 - addresses point 2, references earlier chapter for listenTo…
…/stopListening
fd52da8
@addyosmani For #342 - updating introduction, prelude a99243a
@addyosmani For #342: rewritten why choose backbone section fca756e
@addyosmani For #339: adding missing model definition, updating examples to more …
…readable vars
36fedb4
@dcmaf dcmaf Chapter 1: Fundamentals - correct typos and punctuation 4990e76
@dcmaf dcmaf Fixes in Prelude and Extensions (Marionette) sections
- Changed 'foundations' to 'foundation' in prelude.

- Marionette:
  - removed 'this' context argument from calls to listenTo()
  - fixed zombie example to use Derick instances rather than Person
  - changed 'in to' to 'into'
0d2024e
@dcmaf dcmaf Changed first view in memory management example to use on rather than…
… listenTo to make it consistent with discussion text.
eb74d2b
@jan-molak jan-molak 03-internals.md listeners example no longer refers to nonexistent 'co…
…mplete' attribute.
46841e7
@addyosmani For #333 - adds new comment lines for changes to view fb04a95
@addyosmani For #348: Corrections to model examples, changing hint comments to be…
… more readable, adding a few extra comments to examples
fe6d7ca
@addyosmani Fixes #337 - adds a number of sane changes to allow the first example…
…s to be run
a9e5bb6
@addyosmani Fixes #386 - adds boilerplate, links to jsfiddle/bin, instructions fo…
…r console testing for internals chapter
8ad8a81
@addyosmani Fixes #362 - adds extended paragraphs about the extensions chapter 9d1f921
@dcmaf dcmaf Prelude: rewrote opening few paragraphs to try to make it stronger
and "drive the point home" as requested in Jeremy's review.
13f74b3
@addyosmani For #339: some clarifications for Thorax section 13b9d7b
@addyosmani For #328: drop unbind() reference, line referring to removed section a85d643
@addyosmani For #328 - correcting undefined this.child in example e1aa591
@addyosmani For #342 - some improvements, adding in nested models/collections piece 1b63a0d
@addyosmani For #342 - simplifying what does mvc give us summary f07e84b
@addyosmani For #342 - addressing further feedback 5663503
@addyosmani For #342 - first take at improving mvc applied to the web a5c1faf
@addyosmani For #342 - lots of updates to the mvc in the browser/client-side mvc …
…section
d75bbe0
@addyosmani For #342 - updates model paragraph ae3ebf3
@addyosmani For #342 - updates validation in internals 9eb9fbc
@addyosmani Fixes #322 - adds more details about yeoman with differences between …
…it and bbb. Also added a mention of backbone devtools for kicks
fe349aa
@addyosmani For #387 - addresses point 2, references earlier chapter for listenTo…
…/stopListening
5e6bee9
@addyosmani Fixes #322 - adds more details about yeoman with differences between …
…it and bbb. Also added a mention of backbone devtools for kicks

some corrections

refactored graphic, ,1/3 to more explanations for BasicView

gitignore

refactored graphic, ,2/3 to more explanations for BasicView

refactored graphic, 2a/3 to more explanations for BasicView

my changes all again about mobile chapter

some corrections

refactored graphic, ,1/3 to more explanations for BasicView

gitignore

refactored graphic, ,2/3 to more explanations for BasicView

refactored graphic, 2a/3 to more explanations for BasicView

small missing code syntax

update to grunt 0.4.0

fix update to grunt 0.4.0, enhance multi plattform support section

several layouting corrections, small enhancements, adaption of image sizing
95a40b0
@raDiesle raDiesle grammar and vocabulary corrections page 1 and 2 of 14 bc473e8
@raDiesle raDiesle grammar and vocabulary corrections page 3-14 of 14 0b190e2
@raDiesle

I think it is a good idea to trigger the pull request.
Is the fork rebased correct?

Thanks

@addyosmani
Owner

It looks like the pull request can't be automatically merged. Would you like to rebase or create a fresh pull request with only those files that have changed?

and others added some commits
@addyosmani Linking up Front Controller pattern 5dec61b
@addyosmani Minor updates b93b9ac
@raDiesle raDiesle my changes all again about mobile chapter
some corrections

refactored graphic, ,1/3 to more explanations for BasicView

gitignore

refactored graphic, ,2/3 to more explanations for BasicView

refactored graphic, 2a/3 to more explanations for BasicView

my changes all again about mobile chapter

some corrections

refactored graphic, ,1/3 to more explanations for BasicView

gitignore

refactored graphic, ,2/3 to more explanations for BasicView

refactored graphic, 2a/3 to more explanations for BasicView

small missing code syntax

update to grunt 0.4.0

fix update to grunt 0.4.0, enhance multi plattform support section

several layouting corrections, small enhancements, adaption of image sizing

Fixes #322 - adds more details about yeoman with differences between it and bbb. Also added a mention of backbone devtools for kicks

some corrections

refactored graphic, ,1/3 to more explanations for BasicView

gitignore

refactored graphic, ,2/3 to more explanations for BasicView

refactored graphic, 2a/3 to more explanations for BasicView

my changes all again about mobile chapter

some corrections

refactored graphic, ,1/3 to more explanations for BasicView

gitignore

refactored graphic, ,2/3 to more explanations for BasicView

refactored graphic, 2a/3 to more explanations for BasicView

small missing code syntax

update to grunt 0.4.0

fix update to grunt 0.4.0, enhance multi plattform support section

several layouting corrections, small enhancements, adaption of image sizing

grammar and vocabulary corrections page 1 and 2 of 14

grammar and vocabulary corrections page 3-14 of 14
4141459
@raDiesle raDiesle Merge remote-tracking branch 'origin/gh-pages' into gh-pages
Conflicts:
	backbone-fundamentals.md
	backbone-fundamentals.rtf
	chapters/02-fundamentals.md
	index.html
ac6517a
@raDiesle

Hm, does this looks better?
If not, I will request some help.

Sorry for inconvenience!

Thanks

@addyosmani
Owner

Not at all! It looks like the PR can't be automatically merged but if you would like we can manually bring in the new chapter, update the chapter numbers after it and integrate the content. Would that be easier?

@dcmaf if you get a chance, it would be tremendously useful to get your OK on the content. I'm re-reviewing now but always useful to know if I've missed anything :)

@dcmaf
Collaborator

I'm running through it now and plan on pushing fixes for a few typos. If you can get this updated Mobile chapter merged in then I'll try to give that a read-through as well.

@addyosmani
Owner

I've manually merged the updated mobile section in. Thanks so much for your time and effort spent getting this shaped up and written.

@dcmaf I'll leave this open so that we can track/discuss any major changes that are needed. I trust you with any tweaks/typos :)

@dcmaf
Collaborator

In the opening section it says there are two main principles we need to understand. Am I correct in interpreting these to be progressive enhancement and responsive web design?

@raDiesle

Yep, if it is not clear, feel free to add information !

@dcmaf
Collaborator

I have submitted a pull request (#395) with my changes. Definitely needs to be reviewed and any loss of meaning/intention corrected!

@addyosmani
Owner

With #395 now merged, this chapter should be good to go. A big thank you for all of the help in bringing this together :)

@addyosmani addyosmani closed this
@raDiesle

More was needed to be changed than expected.
Thank you for your support !
I will check again for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 19, 2013
  1. @raDiesle
Commits on Mar 20, 2013
  1. @raDiesle

    some corrections

    raDiesle authored
Commits on Mar 23, 2013
  1. @raDiesle
  2. @raDiesle

    gitignore

    raDiesle authored
  3. @raDiesle
Commits on Mar 24, 2013
  1. @raDiesle
  2. @raDiesle
  3. @raDiesle

    some corrections

    raDiesle authored
  4. @raDiesle
  5. @raDiesle

    gitignore

    raDiesle authored
  6. @raDiesle
  7. @raDiesle
  8. @raDiesle
Commits on Mar 27, 2013
  1. @raDiesle

    small missing code syntax

    raDiesle authored
  2. @raDiesle

    update to grunt 0.4.0

    raDiesle authored
Commits on Mar 29, 2013
  1. Merge pull request #389 from dcmaf/gh-pages

    authored
    Update to Prelude
  2. @raDiesle
  3. Fixes #322 - adds more details about yeoman with differences between …

    authored
    …it and bbb. Also added a mention of backbone devtools for kicks
  4. @raDiesle
  5. @raDiesle

    For #342 - updating introduction, prelude

    authored raDiesle committed
  6. @raDiesle

    For #342: rewritten why choose backbone section

    authored raDiesle committed
  7. @raDiesle

    For #339: adding missing model definition, updating examples to more …

    authored raDiesle committed
    …readable vars
  8. @dcmaf @raDiesle

    Chapter 1: Fundamentals - correct typos and punctuation

    dcmaf authored raDiesle committed
  9. @dcmaf @raDiesle

    Fixes in Prelude and Extensions (Marionette) sections

    dcmaf authored raDiesle committed
    - Changed 'foundations' to 'foundation' in prelude.
    
    - Marionette:
      - removed 'this' context argument from calls to listenTo()
      - fixed zombie example to use Derick instances rather than Person
      - changed 'in to' to 'into'
  10. @dcmaf @raDiesle

    Changed first view in memory management example to use on rather than…

    dcmaf authored raDiesle committed
    … listenTo to make it consistent with discussion text.
  11. @jan-molak @raDiesle

    03-internals.md listeners example no longer refers to nonexistent 'co…

    jan-molak authored raDiesle committed
    …mplete' attribute.
  12. @raDiesle

    For #333 - adds new comment lines for changes to view

    authored raDiesle committed
  13. @raDiesle

    For #348: Corrections to model examples, changing hint comments to be…

    authored raDiesle committed
    … more readable, adding a few extra comments to examples
  14. @raDiesle

    Fixes #337 - adds a number of sane changes to allow the first example…

    authored raDiesle committed
    …s to be run
  15. @raDiesle

    Fixes #386 - adds boilerplate, links to jsfiddle/bin, instructions fo…

    authored raDiesle committed
    …r console testing for internals chapter
  16. @raDiesle
  17. @dcmaf @raDiesle

    Prelude: rewrote opening few paragraphs to try to make it stronger

    dcmaf authored raDiesle committed
    and "drive the point home" as requested in Jeremy's review.
  18. @raDiesle

    For #339: some clarifications for Thorax section

    authored raDiesle committed
  19. @raDiesle
  20. @raDiesle

    For #328 - correcting undefined this.child in example

    authored raDiesle committed
  21. @raDiesle
  22. @raDiesle

    For #342 - simplifying what does mvc give us summary

    authored raDiesle committed
  23. @raDiesle

    For #342 - addressing further feedback

    authored raDiesle committed
  24. @raDiesle

    For #342 - first take at improving mvc applied to the web

    authored raDiesle committed
  25. @raDiesle

    For #342 - lots of updates to the mvc in the browser/client-side mvc …

    authored raDiesle committed
    …section
  26. @raDiesle

    For #342 - updates model paragraph

    authored raDiesle committed
  27. @raDiesle

    For #342 - updates validation in internals

    authored raDiesle committed
  28. @raDiesle

    Fixes #322 - adds more details about yeoman with differences between …

    authored raDiesle committed
    …it and bbb. Also added a mention of backbone devtools for kicks
  29. @raDiesle

    For #387 - addresses point 2, references earlier chapter for listenTo…

    authored raDiesle committed
    …/stopListening
  30. @raDiesle

    Fixes #322 - adds more details about yeoman with differences between …

    authored raDiesle committed
    …it and bbb. Also added a mention of backbone devtools for kicks
    
    some corrections
    
    refactored graphic, ,1/3 to more explanations for BasicView
    
    gitignore
    
    refactored graphic, ,2/3 to more explanations for BasicView
    
    refactored graphic, 2a/3 to more explanations for BasicView
    
    my changes all again about mobile chapter
    
    some corrections
    
    refactored graphic, ,1/3 to more explanations for BasicView
    
    gitignore
    
    refactored graphic, ,2/3 to more explanations for BasicView
    
    refactored graphic, 2a/3 to more explanations for BasicView
    
    small missing code syntax
    
    update to grunt 0.4.0
    
    fix update to grunt 0.4.0, enhance multi plattform support section
    
    several layouting corrections, small enhancements, adaption of image sizing
  31. @raDiesle
Commits on Mar 30, 2013
  1. @raDiesle
  2. Minor updates

    authored
  3. @raDiesle

    my changes all again about mobile chapter

    raDiesle authored
    some corrections
    
    refactored graphic, ,1/3 to more explanations for BasicView
    
    gitignore
    
    refactored graphic, ,2/3 to more explanations for BasicView
    
    refactored graphic, 2a/3 to more explanations for BasicView
    
    my changes all again about mobile chapter
    
    some corrections
    
    refactored graphic, ,1/3 to more explanations for BasicView
    
    gitignore
    
    refactored graphic, ,2/3 to more explanations for BasicView
    
    refactored graphic, 2a/3 to more explanations for BasicView
    
    small missing code syntax
    
    update to grunt 0.4.0
    
    fix update to grunt 0.4.0, enhance multi plattform support section
    
    several layouting corrections, small enhancements, adaption of image sizing
    
    Fixes #322 - adds more details about yeoman with differences between it and bbb. Also added a mention of backbone devtools for kicks
    
    some corrections
    
    refactored graphic, ,1/3 to more explanations for BasicView
    
    gitignore
    
    refactored graphic, ,2/3 to more explanations for BasicView
    
    refactored graphic, 2a/3 to more explanations for BasicView
    
    my changes all again about mobile chapter
    
    some corrections
    
    refactored graphic, ,1/3 to more explanations for BasicView
    
    gitignore
    
    refactored graphic, ,2/3 to more explanations for BasicView
    
    refactored graphic, 2a/3 to more explanations for BasicView
    
    small missing code syntax
    
    update to grunt 0.4.0
    
    fix update to grunt 0.4.0, enhance multi plattform support section
    
    several layouting corrections, small enhancements, adaption of image sizing
    
    grammar and vocabulary corrections page 1 and 2 of 14
    
    grammar and vocabulary corrections page 3-14 of 14
  4. @raDiesle

    Merge remote-tracking branch 'origin/gh-pages' into gh-pages

    raDiesle authored
    Conflicts:
    	backbone-fundamentals.md
    	backbone-fundamentals.rtf
    	chapters/02-fundamentals.md
    	index.html
Something went wrong with that request. Please try again.