Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require once + Second execution fix #117

Merged
merged 5 commits into from Nov 29, 2014
Merged

Require once + Second execution fix #117

merged 5 commits into from Nov 29, 2014

Conversation

mhmxs
Copy link
Contributor

@mhmxs mhmxs commented Jul 22, 2014

There was an error around the execute: false, second time it used the source.execute, which was true. See basket.js:144

@mhmxs
Copy link
Contributor Author

mhmxs commented Aug 8, 2014

Is there any chance to merge this changeset into your project?

@addyosmani
Copy link
Owner

I've reviewed. These changes LGTM for a merge.

addyosmani added a commit that referenced this pull request Nov 29, 2014
Require once + Second execution fix
@addyosmani addyosmani merged commit 1983504 into addyosmani:gh-pages Nov 29, 2014
@addyosmani addyosmani mentioned this pull request Nov 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants