Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Access html via http? #19
Love this module, however a lot of sites are sourced from templates. This means an additional step of curl-ing the rendered html to disk and then using that as the source for the module. This creates some added complexity that would prevent a lot of folks from using it. Since
There are two directions we could go here. One is adding support for just throwing raw HTML at Critical so you don't have to write to disk (simpler) and the other is adding support for remote resources. One argument for not going for the latter is that it's not too much additional code to get Critical working with http separately.
If we go down the remote path, I think you'd need to keep in mind that Oust will want to try extracting all of the remote stylesheets and that would need to be factored in as well. If you could talk about how you would solve this in more detail we could consider it further.
cc @sindresorhus for an FYI.