Support media attribute #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can extract them when we build the CSS later
Need to check for presence of media and extract manually (rather than use `urlObj`) to support local filesystem references.
bookwyrm
changed the title
bezoerb
reviewed
Jul 17, 2021
| @@ -391,6 +393,14 @@ function getStylesheetHrefs(file) { | |||
| return Buffer.from(link.value); | |||
| } | |||
|
|
|||
| if (hasMeaningfulMedia(link.$el)) { | |||
| if (link.value.includes('?')) { | |||
| link.value += `&media=${encodeURI(link.$el.attr('media'))}`; | |||
There was a problem hiding this comment.
i don't think we should append query params to the stylesheet links. This could lead to errors as we don't always know how these are processed by the server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to wrap CSS with media query if the original
linkhas amediaattribute.Fixes #443