Some changes I found while reading #59

Merged
merged 1 commit into from Oct 28, 2012

Projects

None yet

2 participants

@wesleytodd
Contributor
  • Typo fixes
  • Minor code example errors
  • Added section links to all #id'd section headers, also added a little style flourish so they only show on hover, just thought it looked nice :)
@wesleytodd wesleytodd Cherry-picked merge made on master to 1.5.2
- Typo fixes
- Minor code example errors
- Added section links to all #id'd section headers
445c9b7
@wesleytodd wesleytodd commented on the diff Sep 15, 2012
book/index.html
@@ -3611,7 +3658,7 @@ <h2 id="decoratorpatternjavascript">The Decorator Pattern</h2>
<p>They can be used to modify existing systems where we wish to add additional features to objects without the need to heavily modify the underlying code using them. A common reason why developers use them is their applications may contain features requiring a large quantity of distinct types of object. Imagine having to define hundreds of different object constructors for say, a JavaScript game.</p>
-<p>The object constructors could represent distinct player types, each with differing capabilities. A <em>Lord of the Rings</em> game could require constructors for <code>Hobbit</code>, <code>Elf</code>, <code>Ork</code>, <code>Wizard</code>, <code>Mountain Giant</code>, <code>Stone Giant</code> and so on, but there could easily be hundreds of these. If we then factored in capabilities, imagine having to create sub-classes for each combination of capability type e.g <code>HobbitWithRing</code>,<code>HobbitWithSword</code>, <code>HobbitWithRingAndSword</code> and so on.This isn't very practical and certainly isn't manageable when we factor in a growing number of different abilities.</p>
+<p>The object constructors could represent distinct player types, each with differing capabilities. A <em>Lord of the Rings</em> game could require constructors for <code>Hobbit</code>, <code>Elf</code>, <code>Orc</code>, <code>Wizard</code>, <code>Mountain Giant</code>, <code>Stone Giant</code> and so on, but there could easily be hundreds of these. If we then factored in capabilities, imagine having to create sub-classes for each combination of capability type e.g <code>HobbitWithRing</code>,<code>HobbitWithSword</code>, <code>HobbitWithRingAndSword</code> and so on.This isn't very practical and certainly isn't manageable when we factor in a growing number of different abilities.</p>
@wesleytodd
wesleytodd Sep 15, 2012 Contributor

Ork = Orc

@wesleytodd wesleytodd commented on the diff Sep 15, 2012
book/index.html
@@ -7101,9 +7183,9 @@ <h2 id="builderpatternjquery">The Builder Pattern</h2>
<pre class="brush: js">
-$( "&lt;div class= "foo"&gt;bar&lt;/div&gt;" );
+$( '&lt;div class="foo"&gt;bar&lt;/div&gt;' );
@wesleytodd
wesleytodd Sep 15, 2012 Contributor

Switched out the double quote for single because there were nested double quotes.

@wesleytodd wesleytodd referenced this pull request Sep 23, 2012
Closed

Typo in 'Mixins' Section #58

@addyosmani
Owner

Thanks! These will get merged soon.

@addyosmani addyosmani merged commit c047d5c into addyosmani:1.5.2 Oct 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment